Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the warning on nddata.NDUncertainty.propagate #16332

Open
hayesla opened this issue Apr 23, 2024 · 1 comment
Open

Improve the warning on nddata.NDUncertainty.propagate #16332

hayesla opened this issue Apr 23, 2024 · 1 comment
Labels

Comments

@hayesla
Copy link
Contributor

hayesla commented Apr 23, 2024

Description

Currently if a user tries to propagate errors (i.e. nddata.NDUncertainty.propagate) with an operation not currently supported (e.g. np.power) it will error with a ValueError

>>> ValueError: unsupported operation: power

however, it would be better to be a NotImplementedError?

@hayesla hayesla added the Bug label Apr 23, 2024
@neutrinoceros
Copy link
Contributor

Thank you for reporting !
I agree that this error is a bit confusing and that NotImplementedError would make more sense here
For convenience, here's the context it's emitted from:

raise ValueError(f"unsupported operation: {operation.__name__}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants