-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atuin Daemon improvements #2008
Comments
Couple things I noticed trying it out:
|
Are there any plans to integrate other functionality into the daemon? I've noticed rarely sometimes auto-completion is delayed, I presume it's something similar to #2042 where the sqlite database is locked by the daemon for a while because of #952, so the client trying to search the history for autocompletion gets blocked. If history queries were also proxied through to the daemon that would avoid this issue. I also assume setting up the daemon connection should be faster than opening the database so that might even reduce the latency slightly. |
Potentially other functionality yes, but not that I'm afraid. The database is only locked for the duration of the write transaction, which generally should not be more than single digit ms. That sort of functionality is only beneficial for users of ZFS (and maybe btrfs, though I don't know of many people using that), and there's only so much complexity I'm willing to add to workaround the poor interaction of ZFS/SQLite. Realistically the serialization/"network call"/grpc server steps would lead to a slight decrease in performance for everybody else, vs making a sqlite query to an embedded database. |
While the daemon has now been merged, as of #2006, there are a few things left to improve it
The text was updated successfully, but these errors were encountered: