Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Replace: false" option does not work. #3

Open
SimonChris opened this issue Sep 23, 2017 · 2 comments
Open

"Replace: false" option does not work. #3

SimonChris opened this issue Sep 23, 2017 · 2 comments

Comments

@SimonChris
Copy link

When setting "replace" to false, PhotoJShop() still returns undefined, rather than returning the dataURL, Looking at the source code, this is because PhotoJShop() does not return the result of applyEffect(). It just calls it and then returns.

@SimonChris SimonChris changed the title "Replace: all" option does not work. "Replace: false" option does not work. Sep 23, 2017
@aurbano
Copy link
Owner

aurbano commented Sep 25, 2017

Good catch!

Feel free to send a PR if you fix this issue :)

@SimonChris
Copy link
Author

Thanks :). I did manage to fix the issue, by simply adding some return statements. I'll see about making a PR, but I'm pretty busy right now, so I can't say when it will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants