Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization needs some improvement for right to left languages such as persian language #521

Open
wikiccu opened this issue Nov 21, 2020 · 4 comments

Comments

@wikiccu
Copy link
Contributor

wikiccu commented Nov 21, 2020

After changing the default language of project and translation of the files I realized that some part of the application doesn't change
such as the add to cart button.
I've forked your great application and translate it to Persian with some changes for the right to left languages that I will send my pull request in the future in this issue if there is not any problem in this way
Regards.

@indpurvesh
Copy link
Member

@wikiccu

Sure just make sure that you do PR on developed branch please.

@indpurvesh
Copy link
Member

@wikiccu

I have added this as in how to add configuration and use it with @Currency blade

If you want you can do below with Persian language support

https://avored.com/discussion/currency-blade-with-configuration-option

@wikiccu
Copy link
Contributor Author

wikiccu commented Nov 24, 2020

I have added a bit of CSS code in your app.css that can make an RTL direction for the website.
but I'm not sure what is the general idea of avored team that whenever language code changed to an RTL language.
so I should make another CSS file or just inner CSS must handle it?

@indpurvesh
Copy link
Member

indpurvesh commented Nov 27, 2020

At this stage I haven’t thought about Rtl Lang option. But in my opinion seperate file feels best option.

@wikiccu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants