Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DotNet 8.0 Support #443

Merged
merged 8 commits into from
Apr 7, 2024
Merged

Add DotNet 8.0 Support #443

merged 8 commits into from
Apr 7, 2024

Conversation

BroMarduk
Copy link
Contributor

  • Added DotNet 8.0 Libraries
  • Rewrote some functions to support previous versions of frameworks for Utilites (support back to NetStandard2.0)

@@ -1,4 +1,6 @@
using System.Collections;
#if NET6_0_OR_GREATER
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This utility will not run with .NetStandard 2.0 without more fixes so excluding it from utilities for now.

@@ -153,7 +153,7 @@ public static List<FunctionDefinition> GetFunctionDefinitions(Type type)
throw new InvalidFunctionCallException($"Method '{functionCall.Name}' on type '{obj.GetType()}' not found");
}

if (!methodInfo.ReturnType.IsAssignableTo(typeof(T)))
if (!typeof(T).IsAssignableFrom(methodInfo.ReturnType))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsAssignableTo not supported in .NetStandard 2.0 so reversed it to IsAssignableFrom for support.

@kayhantolga kayhantolga linked an issue Dec 7, 2023 that may be closed by this pull request
@kayhantolga
Copy link
Member

I have reverted the changes in the utilization library. The utilization library does not support, and will not support, legacy versions, including .NET 6 and .NET 7.

@kayhantolga kayhantolga added the Ready for next version This issue solved and waiting for next release label Apr 3, 2024
@kayhantolga kayhantolga modified the milestones: 7.4.7, 8.0.0 Apr 3, 2024
@kayhantolga kayhantolga merged commit 6cb7989 into betalgo:dev Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for next version This issue solved and waiting for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrading to .NET8.0
2 participants