-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guix: SOURCE_DATE_EPOCH is already set in some environments #29935
Comments
As we run Guix shell in a container, it seems reasonable to rename
|
Sounds good to me. I think it's fine to rename it, I think there's really very few edge cases in which one would really want to pass in a custom epoch to the guix build? |
Not sure. We already have FORCE_DIRTY_WORKTREE. Seems fine to just make SOURCE_DATE_EPOCH function in the same way, rather than new variables / more build options / things being less-standard. |
That sounds like a good approach to me too. So, fail when |
Or could cover |
The environment variable
SOURCE_DATE_EPOCH
allows overriding the date that will be used inside the archives for guix-built binaries. This is an intentional feature, as documented incontrib/guix/README.md
:However, some environments, as apparently Nix, set
SOURCE_DATE_EPOCH
by default. This can be extremely confusing, as it results in mismatches. i see three options:SOURCE_DATE_EPOCH
. Most likely it's not what the user wanted, but they can continue if they wanted.SOURCE_DATE_EPOCH
- unset it at start.SOURCE_DATE_EPOCH
to something non-standard that doesn't conflict with Nix.The first one has my preference.
See bitcoin-core/guix.sigs#1201 which prompted this.
The text was updated successfully, but these errors were encountered: