Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative for cairo_xlib_surface_create on other display outputs #1607

Open
mmuman opened this issue Aug 12, 2023 · 3 comments · Fixed by #1844
Open

Provide alternative for cairo_xlib_surface_create on other display outputs #1607

mmuman opened this issue Aug 12, 2023 · 3 comments · Fixed by #1844
Labels
cairo Issue or PR related to cairo feature New feature PR or issue lua Issue or PR related to Lua code

Comments

@mmuman
Copy link
Collaborator

mmuman commented Aug 12, 2023

What happened?

Some conky scripts call cairo_xlib_surface_create to draw, because it is exposed by Lua, which breaks portability to other GUIs.

What should we do about it? Wrap it around some dispatch code?

Version

HEAD

Which OS/distro are you seeing the problem on?

Debian

Conky config

No response

Stack trace

No response

Relevant log output

No response

@mmuman mmuman added bug Bug report or bug fix PR triage Issue that hasn't been verified labels Aug 12, 2023
@Caellian
Copy link
Collaborator

Caellian commented Apr 8, 2024

We could probably add a custom loader for require or override it to always load conky flavor of cairo. (similar issue in sol2)

@Caellian Caellian added lua Issue or PR related to Lua code cairo Issue or PR related to cairo packaging Issue or PR related to conky packaging in general or for a specific distribution and removed triage Issue that hasn't been verified labels Apr 17, 2024
@Caellian Caellian added the dependencies Issue or PR that affects dependencies label Apr 30, 2024
@Caellian
Copy link
Collaborator

Oh, I thought the issue was that require 'cairo' would include system libraries instead of conky ones.

My new understanding of this issue is that cairo_xlib_surface_create doesn't work with Wayland display output.

I'm repurposing this issue as it has been addressed by #1844.

@Caellian Caellian linked a pull request Apr 30, 2024 that will close this issue
@Caellian Caellian changed the title [Bug]: cairo_xlib_surface_create call exposed to Lua breaks other GUIs Provide alternative for cairo_xlib_surface_create on other display outputs Apr 30, 2024
@Caellian Caellian added feature New feature PR or issue and removed bug Bug report or bug fix PR dependencies Issue or PR that affects dependencies packaging Issue or PR related to conky packaging in general or for a specific distribution labels Apr 30, 2024
@Caellian
Copy link
Collaborator

In future, it would be nice to add some generic function that handles surface creation regardless of currently used display output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cairo Issue or PR related to cairo feature New feature PR or issue lua Issue or PR related to Lua code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants