Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][UI]: Invoices could be permanently filtered via SearchTerm stored in cookies #5984

Closed
1 task done
mizhgan opened this issue May 15, 2024 · 1 comment · Fixed by #5986
Closed
1 task done

[Bug][UI]: Invoices could be permanently filtered via SearchTerm stored in cookies #5984

mizhgan opened this issue May 15, 2024 · 1 comment · Fixed by #5986
Assignees
@dennisreimann
Labels
Bug UI / UX Front-end issues, for front-end designers
Milestone
1.13.x

Comments

@mizhgan
Copy link

mizhgan commented May 15, 2024

What is your BTCPay version?

I'm running BTCPay Server v1.13.1+ca55e1f30

How did you deploy BTCPay Server?

I'm running BTCPay Server on dedicated VPS deployed with Docker

What happened?

If you are filtering out Invoices list by clicking "Invoices" in Requests list - it goes into cookies and Invoices list became filtered forever

How did you encounter this bug?

  1. Install BTCPay server
  2. Create store and wallet
  3. Make some invoices
  4. Make a Payment Request
  5. Open that request and try to pay it, that should create invoices with Order Id linked to request - e.g. PAY_REQUEST_ID
  6. Observe that now we have different invoices in Invoices list
  7. Go to Requests page, click three dots at the end of the request row and click "Invoices"
  8. Observe Invoices list which only contain invoices that linked to the request
  9. Click anywhere else on the web UI and click again on the Invoices - you should return to the Invoices list which will be still filtered by the request with no obvious way to reset this filter

Relevant log output

No response

What browser do you use?

Chrome 124.0.6367.119

Additional information

There are three ways to reset filter:

  1. LogOut-LogIn
  2. Put focus on search input in Invoices page, press Enter, that will bring params into URL, delete SearchTerm content in URL, press Enter to reload page
  3. Delete SearchTerm field from cookies

Are you sure this is a bug report?

  • I confirm this is a bug report
@pavlenex
Copy link
Contributor

@dennisreimann can you look into this one please?

dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue May 16, 2024
@dennisreimann
Search: Display text filters in search input
0915ecd 
This changes the search text input to also display the filters, which don't have a special UI (e.g. dropdown). Those filters (e.g. orderid) were not displayed before and hence could not be reset.

Fixes btcpayserver#5984.
@dennisreimann dennisreimann self-assigned this May 16, 2024
@dennisreimann dennisreimann added this to the 1.13.x milestone May 16, 2024
@dennisreimann dennisreimann added Bug UI / UX Front-end issues, for front-end designers labels May 16, 2024
@dennisreimann dennisreimann mentioned this issue May 16, 2024
Merged
NicolasDorier pushed a commit that referenced this issue May 23, 2024
@dennisreimann
Search: Display text filters in search input (#5986)
c063c70 
* Search: Display text filters in search input

This changes the search text input to also display the filters, which don't have a special UI (e.g. dropdown). Those filters (e.g. orderid) were not displayed before and hence could not be reset.

Fixes #5984.

* Add and fix test
NicolasDorier pushed a commit that referenced this issue May 23, 2024
@dennisreimann @NicolasDorier
Search: Display text filters in search input (#5986)
70253cb 
* Search: Display text filters in search input

This changes the search text input to also display the filters, which don't have a special UI (e.g. dropdown). Those filters (e.g. orderid) were not displayed before and hence could not be reset.

Fixes #5984.

* Add and fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisreimann dennisreimann

Labels
Bug UI / UX Front-end issues, for front-end designers
Projects
None yet
Milestone
1.13.x
Development

Successfully merging a pull request may close this issue.

Search: Display text filters in search input dennisreimann/btcpayserver
3 participants
@dennisreimann @mizhgan @pavlenex