Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: booker can reschedule and cancel unconfirmed event from email #15008

Open
anikdhabal opened this issue May 13, 2024 · 1 comment 路 May be fixed by #15013
Open

Bug: booker can reschedule and cancel unconfirmed event from email #15008

anikdhabal opened this issue May 13, 2024 · 1 comment 路 May be fixed by #15013
Labels
馃悰 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email
Milestone

Comments

@anikdhabal
Copy link
Contributor

Found a bug? Please fill out the sections below. 馃憤

Issue Summary

Currently a booker reschedule and cancel unconfirmed event directly from the email.

Steps to Reproduce

  1. book an event that require confirmation
  2. go to the submit email
  3. cancel or reschedule the booking

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Expected Results

Booker couldn't cancel or reschedule an unconfirmed event, as they do not have the ability from the app. Similarly, they shouldn't have the ability from email

Copy link

dosubot bot commented May 13, 2024

To address the issue where a booker can reschedule and cancel unconfirmed events directly from the email, it's crucial to implement a series of checks and updates in the application's logic. Here's a concise plan to resolve this bug:

  1. Verify Event Confirmation Status: Ensure actions are only allowed for events with the appropriate confirmation status.
  2. Check User Permissions: Confirm that the user has the necessary permissions to perform the action.
  3. Respect Event Type Rules: Adhere to specific rules related to the event type, especially for events requiring confirmation or involving round-robin scheduling.
  4. Handle Round-Robin Scheduling: Properly manage events that could be reassigned to a different host upon rescheduling.
  5. Update External Calendar Events: Make sure any changes are reflected in linked external calendars.
  6. Send Appropriate Notifications: Notify all relevant parties about the rescheduling or cancellation.
  7. Log Actions: Keep a record of all actions for auditing and debugging purposes.

For implementation, you might need to review and update the logic in the following parts of the repository:

  • Rescheduling logic in packages/app-store/vital/lib/reschedule.ts
  • Rescheduling tests in packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts

This approach ensures that the application consistently enforces rules for unconfirmed events across both the app and email interactions, aligning with the expected behavior.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 馃憤 if this is helpful and 馃憥 if it is irrelevant.

To continue the conversation, mention @dosu.

@anikdhabal anikdhabal changed the title bug: booker can reschedule and cancel unconfirmed event from email Bug: booker can reschedule and cancel unconfirmed event from email May 13, 2024
@dosubot dosubot bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email 馃悰 bug Something isn't working labels May 13, 2024
@anikdhabal anikdhabal linked a pull request May 13, 2024 that will close this issue
3 tasks
@dosubot dosubot bot added this to the v4.2 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant