Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Refactor ChatAgent #526

Open
2 tasks done
Wendong-Fan opened this issue Apr 23, 2024 · 1 comment · May be fixed by #574
Open
2 tasks done

[Feature Request] Refactor ChatAgent #526

Wendong-Fan opened this issue Apr 23, 2024 · 1 comment · May be fixed by #574
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Wendong-Fan
Copy link
Member

Wendong-Fan commented Apr 23, 2024

Required prerequisites

Motivation

  1. current ChatAgent is redundant, we want to refactor this class to make it more tidy
  2. we need to support passing API Key as parameter into ChatAgent , this feature is required for the platform development
  3. remove ChatGPTVisionConfig , merge FunctionCallingConfig into ChatGPTConfig to make the abstraction tidy as discussed in feat: enable image modality for ChatAgent #473

Solution

  1. Separate initialization of model and chat agent
    refactor: ChatAgent model part #574

  2. model_type ,model_config move to model
    refactor: ChatAgent model part #574

  3. Model.create(platform='', model='',...)
    refactor: ChatAgent model part #574

  4. add config folder, set model config based on framework done by Zecheng
    Remove ChatGPTVisionConfig and refactor configs #539 Add configs folder #540

  5. move from function into tools, remove FunctionCallingConfig and from_openai_function_list , integrate them within ChatGPTConfig
    refactor: move from function to tools #556

  6. passing API Key as parameter into ChatAgent
    feat: ChatAgent support api key as parameter #551

Alternatives

No response

Additional context

No response

@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Apr 23, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 2 milestone Apr 23, 2024
@Wendong-Fan Wendong-Fan self-assigned this Apr 23, 2024
@Wendong-Fan Wendong-Fan changed the title [Feature Request] API Key as parameter into ChatAgent [Feature Request] Refactor ChatAgent Apr 23, 2024
@Wendong-Fan
Copy link
Member Author

Wendong-Fan commented Apr 23, 2024

@ocss884 @zechengz feel free to add content into this issue description

@Wendong-Fan Wendong-Fan modified the milestones: Sprint 2, Sprint 3 May 9, 2024
@Wendong-Fan Wendong-Fan linked a pull request May 23, 2024 that will close this issue
13 tasks
@Wendong-Fan Wendong-Fan linked a pull request May 26, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Sprint Planned
Development

Successfully merging a pull request may close this issue.

3 participants