Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block toolbar's handle tooltip misaligned #16365

Closed
ivukasinovic opened this issue May 13, 2024 · 10 comments · Fixed by #16408
Closed

Block toolbar's handle tooltip misaligned #16365

ivukasinovic opened this issue May 13, 2024 · 10 comments · Fixed by #16408
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui
Milestone

Comments

@ivukasinovic
Copy link

ivukasinovic commented May 13, 2024

We have an issue with the tooltip.
It happens just on the initial loading of the page and while selecting the rich content (hovering over the handle).
After that hovers align correctly.

This is also an issue on the official example from here (check last image)

image
image
image

@Witoso
Copy link
Member

Witoso commented May 14, 2024

Interesting, in our docs/demos it only happens on the first hover. @oleq / @Mati365 / @DawidKossowski, any ideas, I know you were in the tooltips area lately.

@ISilviu
Copy link

ISilviu commented May 15, 2024

Interesting, in our docs/demos it only happens on the first hover

Indeed, could it happen because of a layout shift?

@Mati365
Copy link
Member

Mati365 commented May 15, 2024

@ISilviu I think so, probably editor is moving horizontally a bit during mounting and tooltip manager caches incorrectly start position of tooltip. @Witoso IMO it's internal CKEditor bug not related to React integration.

@ISilviu
Copy link

ISilviu commented May 16, 2024

Shall we re-open the issue on their main repo then?

@Mati365
Copy link
Member

Mati365 commented May 16, 2024

@ISilviu yep

@Witoso Witoso transferred this issue from ckeditor/ckeditor5-react May 16, 2024
@Witoso
Copy link
Member

Witoso commented May 16, 2024

Done.

@Witoso Witoso added package:ui domain:ui/ux This issue reports a problem related to UI or UX. labels May 16, 2024
@ISilviu
Copy link

ISilviu commented May 16, 2024

Thank you!

@ISilviu
Copy link

ISilviu commented May 21, 2024

Has anyone managed to have a look at it?

@Mati365
Copy link
Member

Mati365 commented May 22, 2024

@ISilviu Yep, it's queued. I'll take a look, probably tomorrow.

@Mati365 Mati365 self-assigned this May 23, 2024
@Mati365
Copy link
Member

Mati365 commented May 23, 2024

Notes for further testing. It's fully reproducible in our demos.

Steps:

  1. Edit this file https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-build-balloon-block/tests/manual/ckeditor-cjs-version.html#L1
  2. Add margin and width to #editor div. Like this: <div id="editor" style="width: 400px; margin-left: 200px">
  3. Open http://localhost:8125/ckeditor5-build-balloon-block/tests/manual/ckeditor-cjs-version.html
  4. Hover balloon editor hamburger button and open tooltip.

scofalik added a commit that referenced this issue May 29, 2024
Fix (ui): Fixed incorrect position of the block toolbar tooltip handle. Closes #16365.
@CKEditorBot CKEditorBot added this to the iteration 75 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants