Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a unit test that datalab.issues solely contains numeric and boolean values #937

Open
jwmueller opened this issue Dec 28, 2023 · 1 comment · May be fixed by #946
Open

add a unit test that datalab.issues solely contains numeric and boolean values #937

jwmueller opened this issue Dec 28, 2023 · 1 comment · May be fixed by #946
Labels
code improvement Codebase improvements to address tech debt / inefficiency / redundancy good first issue Good for newcomers help-wanted We need your help to add this, but it may be more challenging than a "good first issue"

Comments

@jwmueller
Copy link
Member

Can go in this file:

https://github.com/cleanlab/cleanlab/blob/master/tests/datalab/test_datalab.py

Also add a second unit test that datalab.issue_summary solely contains numeric values.
@jwmueller jwmueller added good first issue Good for newcomers code improvement Codebase improvements to address tech debt / inefficiency / redundancy help-wanted We need your help to add this, but it may be more challenging than a "good first issue" labels Dec 28, 2023
@01PrathamS 01PrathamS linked a pull request Jan 6, 2024 that will close this issue
Open
@sanjanag
Copy link
Member

sanjanag commented Feb 6, 2024

https://github.com/cleanlab/cleanlab/blob/master/tests/datalab/test_cleanvision_integration.py should also contain a test testing there are solely numeric values in datalab.issues. Currently, it is broken because score column does not extend to cleanvision right now.
Screenshot 2024-02-06 at 3 38 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code improvement Codebase improvements to address tech debt / inefficiency / redundancy good first issue Good for newcomers help-wanted We need your help to add this, but it may be more challenging than a "good first issue"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unittest to test_datalab.py 01PrathamS/cleanlab_
2 participants
@jwmueller @sanjanag