Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement query energy estimation #1231

Closed
joshua-spacetime opened this issue May 14, 2024 · 0 comments · Fixed by #1293
Closed

Implement query energy estimation #1231

joshua-spacetime opened this issue May 14, 2024 · 0 comments · Fixed by #1293
Assignees
@joshua-spacetime

Comments

@joshua-spacetime
Copy link
Collaborator

Requirements:

  • Initial subscription and ad hoc queries whose estimated energy consumption exceeds limit will fail before being executed
  • The energy limit should be configurable at runtime
  • We should have separate limits for owner and non-owner identities

Non-requirements:

  • Energy estimation does not have to be absolutely accurate, but it should be relatively accurate
    • That is if energy(A) >= energy(B), then estimate(A) >= estimate(B)
@joshua-spacetime joshua-spacetime self-assigned this May 14, 2024
joshua-spacetime added a commit that referenced this issue May 23, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries
0ac2fba 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
@joshua-spacetime joshua-spacetime mentioned this issue May 23, 2024
Merged
2 tasks
joshua-spacetime added a commit that referenced this issue May 24, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries
12e4afa 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
joshua-spacetime added a commit that referenced this issue May 30, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries
66fad9b 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
joshua-spacetime added a commit that referenced this issue May 30, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries
f8d92c6 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
joshua-spacetime added a commit that referenced this issue May 30, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries
ce33f21 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
joshua-spacetime added a commit that referenced this issue May 30, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries
bdc7afe 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
github-merge-queue bot pushed a commit that referenced this issue May 30, 2024
@joshua-spacetime
feat(1231): Add a configurable row limit for queries (#1293)
6512f35 
Closes #1231.

Queries that are estimated to exceed this row limit are rejected.
And the same holds for subscriptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-spacetime joshua-spacetime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(1231): Add a configurable row limit for queries clockworklabs/SpacetimeDB
1 participant
@joshua-spacetime