util/log: TestLogEntryPropagation failed

[cockroach-teamcity]

util/log.TestLogEntryPropagation failed on release-24.1.0-rc @ 5e4ca9e26f1a25681de9c944298cfa139c344466:

==================
WARNING: DATA RACE
Write at 0x00000228aa38 by goroutine 311:
  github.com/cockroachdb/cockroach/pkg/util/log.TestLogEntryPropagation()
      github.com/cockroachdb/cockroach/pkg/util/log/clog_test.go:753 +0x3b3
  testing.tRunner()
      GOROOT/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      GOROOT/src/testing/testing.go:1742 +0x44

Previous read at 0x00000228aa38 by goroutine 303:
  github.com/cockroachdb/cockroach/pkg/util/log.(*fileSink).gcOldFiles()
      github.com/cockroachdb/cockroach/pkg/util/log/file_log_gc.go:48 +0xb3
  github.com/cockroachdb/cockroach/pkg/util/log.(*fileSink).gcDaemon()
      github.com/cockroachdb/cockroach/pkg/util/log/file_log_gc.go:36 +0x124
  github.com/cockroachdb/cockroach/pkg/util/log.ApplyConfig.gowrap2()
      github.com/cockroachdb/cockroach/pkg/util/log/flags.go:321 +0x4f

Goroutine 311 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1742 +0x825
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:2161 +0x85
  testing.tRunner()
      GOROOT/src/testing/testing.go:1689 +0x21e
  testing.runTests()
      GOROOT/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:2027 +0xf17
  github.com/cockroachdb/cockroach/pkg/util/log_test.TestMain()
      github.com/cockroachdb/cockroach/pkg/util/log_test/pkg/util/log/main_test.go:29 +0xce
  main.main()
      main/bazel-out/k8-fastbuild/bin/pkg/util/log/log_test_/testmain.go:306 +0x824

Goroutine 303 (finished) created at:
  github.com/cockroachdb/cockroach/pkg/util/log.ApplyConfig()
      github.com/cockroachdb/cockroach/pkg/util/log/flags.go:321 +0x1d44
  github.com/cockroachdb/cockroach/pkg/util/log.newLogScope.func1()
      github.com/cockroachdb/cockroach/pkg/util/log/test_log_scope.go:165 +0x317
  github.com/cockroachdb/cockroach/pkg/util/log.newLogScope()
      github.com/cockroachdb/cockroach/pkg/util/log/test_log_scope.go:172 +0x82e
  github.com/cockroachdb/cockroach/pkg/util/log.ScopeWithoutShowLogs()
      github.com/cockroachdb/cockroach/pkg/util/log/test_log_scope.go:101 +0x45
  github.com/cockroachdb/cockroach/pkg/util/log.TestFileSeverityFilter()
      github.com/cockroachdb/cockroach/pkg/util/log/clog_test.go:647 +0x7b
  testing.tRunner()
      GOROOT/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      GOROOT/src/testing/testing.go:1742 +0x44
==================

Parameters:

• attempt=1
• race=true
• run=1
• shard=1

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

• util/log: TestLogEntryPropagation failed #122791 util/log: TestLogEntryPropagation failed [C-test-failure O-robot P-3 T-observability branch-master]
• util/log: TestLogEntryPropagation failed #121548 util/log: TestLogEntryPropagation failed [A-observability-inf C-test-failure O-robot P-3 T-observability branch-release-24.1]

/cc @cockroachdb/obs-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-38924

[abarganier]

This will be resolved when #124219 is merged.

I'll backport accordingly.

[dhartunian]

Resolved in release-24.1 I don't think the RC branch needs this change. #124542