kvserver: return process error on scatter #124514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to c9cf068, a replica would return any errors processing the range with scatter options via the replicate queue, to the caller. Reinstall this behavior, which informs the caller about any relevant errors. Fixes: cockroachdb#124510 Release note (bug fix): ADMIN SCATTER would not return any processing errors to the client in v24.1.0. ADMIN SCATTER will now return errors encountered during processing, as was the case prior to v24.1.0.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to c9cf068, a replica would return any errors processing the range with scatter options via the replicate queue, to the caller. Reinstall this behavior, which informs the caller about any relevant errors.
Fixes: #124510
Release note (bug fix): ADMIN SCATTER would not return any processing errors to the client in v24.1.0. ADMIN SCATTER will now return errors encountered during processing, as was the case prior to v24.1.0.