Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Chain upgrade causes Comet to error for unsupported key due to empty pubkey type #20318

Closed
1 of 2 tasks
alpe opened this issue May 8, 2024 · 5 comments · Fixed by #20481
Closed
1 of 2 tasks

[Bug]: Chain upgrade causes Comet to error for unsupported key due to empty pubkey type #20318

alpe opened this issue May 8, 2024 · 5 comments · Fixed by #20481
Labels
C: comet S:blocked Status: Blocked T:Bug

Comments

@alpe
Copy link
Contributor

alpe commented May 8, 2024 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

On a chain upgrade from v0.50 to the latest in current main, Comet raises an error: "encoding: unsupported key"
This is due to an empty pubkey type (when state is loaded) on the new binary.

Cosmos SDK Version

main

How to reproduce?

Systemtests for chain upgrade

TODO when fixed
@alpe alpe added the T:Bug label May 8, 2024
@melekes
Copy link
Contributor

melekes commented May 13, 2024

Do you have a stack trace?

@alpe alpe mentioned this issue May 13, 2024
Merged
3 tasks
@alpe
Copy link
Contributor Author

alpe commented May 13, 2024

Screenshot 2024-05-07 at 14 52 32

@tac0turtle
Copy link
Member

Note: remove the test skip in order to close this issue #20367

@melekes melekes mentioned this issue May 14, 2024
Closed
@melekes
Copy link
Contributor

melekes commented May 14, 2024

@alpe could you please check if cometbft/cometbft#3077 fixes the error?

@tac0turtle tac0turtle added C: comet S:blocked Status: Blocked labels May 14, 2024
@alpe
Copy link
Contributor Author

alpe commented May 15, 2024

@melekes thank you for the quick patch! I have tested with #111bf226a9e5 from your branch and it solves the issue on upgrade. Well done! 👏

@melekes melekes mentioned this issue May 15, 2024
Merged
4 tasks
This was referenced May 29, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: comet S:blocked Status: Blocked T:Bug
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Bump CometBFT versions cosmos/cosmos-sdk
3 participants
@alpe @melekes @tac0turtle