Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Prevent overflow in multisig accounts #20362

Closed
1 task done
alpe opened this issue May 13, 2024 · 0 comments · Fixed by #20384
Closed
1 task done

[Bug]: Prevent overflow in multisig accounts #20362

alpe opened this issue May 13, 2024 · 0 comments · Fixed by #20384
Assignees
@facundomedica
Labels
T:Bug

Comments

@alpe
Copy link
Contributor

alpe commented May 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

On Init + Update of the Multisig account, the member's weights are summed. This can lead to an overflow on the uint64 type and unintended behaviour where the values are used

Cosmos SDK Version

main

How to reproduce?

Found this on code review of #20310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

Labels
T:Bug
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(x/accounts): check for overflows in multisig weights and votes cosmos/cosmos-sdk
2 participants
@alpe @facundomedica