-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: App v2 sets "tx" as store key and this fails on the chain upgrade #20317
Comments
It is only a problem when a chain goes from not using depinject to using depinject right? |
We could update runtime to purposely skip Line 205 in fc84ff6
Is that really a problem? If so then we would need to add a field to denotate that a module doesn't have a store key in app_config (
|
hmm, is there anyway to make this part of depinject? seems we are uncovering edge cases that may prevent users from using depinject. IBC also has a case |
This has nothing to do with depinject, but a runtime v1 assumption, which requires a runtime change. |
option 2 seems the best, we just need to document it 👍 |
Is there an existing issue for this?
What happened?
App v2 sets "tx" as store key and this fails on the chain upgrade with the error: version of store tx mismatch
(app v1 is not affected)
Cosmos SDK Version
main
How to reproduce?
Run chain upgrade with system tests for app v2
The text was updated successfully, but these errors were encountered: