{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":39242894,"defaultBranch":"master","name":"coturn","ownerLogin":"coturn","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-07-17T08:15:16.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6572098?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716836425.0","currentOid":""},"activityList":{"items":[{"before":"d1db5e590d502c0e2b085b929d07a578a877bee0","after":"868f15a67249b18eea763ce5199ec0334f211adc","ref":"refs/heads/master","pushedAt":"2024-06-02T01:16:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Move the hiredis_libevent2 code from common to relay (#1509)\n\nThe point of this change is to make the build instructions a bit more\r\nstraight forward. Since the hiresevent2 source files are only ever used\r\nby the relay target, this scoping makes sense in general.","shortMessageHtmlLink":"Move the hiredis_libevent2 code from common to relay (#1509)"}},{"before":"ebf7587aaff7821c590d4b95a0d04a768344dde1","after":"d1db5e590d502c0e2b085b929d07a578a877bee0","ref":"refs/heads/master","pushedAt":"2024-06-02T01:13:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Include what you use (#1512)\n\nUse the include-what-you-use program to (partially) clean up header\r\nincludes, so that only includes which are needed, and no includes that\r\nare not needed (or at least closer to that ideal) are done.\r\n\r\nFor a c-language project, the build-time improvements from this change\r\nis minimal. This would have a much bigger impact on a C++ project than a\r\nC-project for build times.\r\n\r\nSo for coturn, this change is mostly intended to just provide\r\nconsistency and make it easier to locate weird issues like strange\r\ndependencies, and unnecessary connections between code.","shortMessageHtmlLink":"Include what you use (#1512)"}},{"before":"e45d846331070882cb98a64b0a8800e0e01aba5d","after":"ebf7587aaff7821c590d4b95a0d04a768344dde1","ref":"refs/heads/master","pushedAt":"2024-06-02T01:10:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Remove deprecated macos-11, add macos-13 and macos-14 (#1511)","shortMessageHtmlLink":"Remove deprecated macos-11, add macos-13 and macos-14 (#1511)"}},{"before":"35a3293531f07bf70a6e36388cd59507dfa90652","after":"e45d846331070882cb98a64b0a8800e0e01aba5d","ref":"refs/heads/master","pushedAt":"2024-05-30T03:49:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Check the result of malloc in string_list_add (#1495)","shortMessageHtmlLink":"Check the result of malloc in string_list_add (#1495)"}},{"before":"66a85ef09e277aa3fcdbc8448832afba71b787db","after":"35a3293531f07bf70a6e36388cd59507dfa90652","ref":"refs/heads/master","pushedAt":"2024-05-30T03:48:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Check the result of realloc and calloc in ch_map_get (#1497)","shortMessageHtmlLink":"Check the result of realloc and calloc in ch_map_get (#1497)"}},{"before":"99777bd585af97c5f2763d32bb0c4544bee859fc","after":"66a85ef09e277aa3fcdbc8448832afba71b787db","ref":"refs/heads/master","pushedAt":"2024-05-30T03:44:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Address clang-tidy warnings in db files (#1405)\n\nThe general approach here was:\r\n\r\n- Always declare variables as close to where they are defined as\r\npossible.\r\n- Check for pre-conditions of functions before doing work (e.g. ensure\r\nwe can connect to the DB before doing a bunch of string formatting)\r\n- Keep the scope of mutexes as reasonably small as practical.\r\n- Use idiomatic C11, such as for-loops over the thing being iterated,\r\nnot while() loops over constants, or variables that aren't modified.\r\n- Prefer if(fail){return} function-body after over `if(not fail){\r\nfunction-body inside if} return;\r\n\r\nClang-tidy returns a clean bill of health, but while going through this\r\nfile i noticed a lot of things that raise questions.\r\n\r\nLack of checking column counts. Lack of handling the possibility of\r\nmultiple return values. Questionably handling of strings. Complete lack\r\nof checking function inputs for invalid values (e.g. nullptr).\r\n\r\nI'm not going to fix those, my organization doesn't USE the DB drivers,\r\nso i have little interest in re-working the logic beyond addressing\r\nclang-tidy warnings for my own sanity, but i did add TODO comments for\r\nsomeone else to look at in the future.\r\n\r\n\r\n\r\nAdditional note: While the changes look very invasive.... they aren't.\r\n\r\nI don't think there is a way to get github to ignore whitespace in the\r\nfilediff, but if someone were to compare the commit locally, they'll see\r\nthat almost all of the changes are just adjusting indentation.","shortMessageHtmlLink":"Address clang-tidy warnings in db files (#1405)"}},{"before":"ad94684b233a979588a30d9e255b96e00bcc146c","after":"99777bd585af97c5f2763d32bb0c4544bee859fc","ref":"refs/heads/master","pushedAt":"2024-05-30T03:42:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"malloc now allocates space for string terminator (#1507)\n\naddresses a code scanner vulnerability\r\n\r\nthe combination of `strlen` and `malloc` results in space being\r\nallocated for the string, but not the null terminator required to end\r\nthe string, so space for an extra character has to be manually specified\r\n\r\n#### references\r\n- CERT C Coding Standard: [MEM35-C. Allocate sufficient memory for an\r\nobject](https://www.securecoding.cert.org/confluence/display/c/MEM35-C.+Allocate+sufficient+memory+for+an+object).\r\n- Common Weakness Enumeration:\r\n[CWE-131](https://cwe.mitre.org/data/definitions/131.html).\r\n- Common Weakness Enumeration:\r\n[CWE-120](https://cwe.mitre.org/data/definitions/120.html).\r\n- Common Weakness Enumeration:\r\n[CWE-122](https://cwe.mitre.org/data/definitions/122.html).","shortMessageHtmlLink":"malloc now allocates space for string terminator (#1507)"}},{"before":"58dc071b46b714a4403b71fd67889fc392aece0c","after":"ad94684b233a979588a30d9e255b96e00bcc146c","ref":"refs/heads/master","pushedAt":"2024-05-30T03:39:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Use bool over int for the turnutils_uclient program (#1420)\n\nConverts all of the variables in the uclient program that should be bool\r\nbut weren't.\r\n\r\nA few other minor adjustments made at the behest of clang-tidy, but this\r\nchange does not address all of clang-tidy's complaints.","shortMessageHtmlLink":"Use bool over int for the turnutils_uclient program (#1420)"}},{"before":"6f82083ea335b101a0a85d6337fcee858282b3af","after":"58dc071b46b714a4403b71fd67889fc392aece0c","ref":"refs/heads/master","pushedAt":"2024-05-30T02:07:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Fix lint complaint about comment (#1506)","shortMessageHtmlLink":"Fix lint complaint about comment (#1506)"}},{"before":"e8fa2f666ab7334ec8973e04c967ab3efd62a5d3","after":"6f82083ea335b101a0a85d6337fcee858282b3af","ref":"refs/heads/master","pushedAt":"2024-05-27T20:50:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Run all of the CI except for Docker builds on any change (#1415)\n\nI'm having trouble testing changes in my own fork because many of the CI\r\nworkflows are only set to build on a pull request.\r\n\r\nBetter to just build on any commit.\r\n\r\nI've left the docker builds as they are.","shortMessageHtmlLink":"Run all of the CI except for Docker builds on any change (#1415)"}},{"before":"544382f313968c73d77ec801b931dfeefae96346","after":"e8fa2f666ab7334ec8973e04c967ab3efd62a5d3","ref":"refs/heads/master","pushedAt":"2024-05-27T20:47:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Avoid read-past-end of string in get_bold_admin_title (#1499)","shortMessageHtmlLink":"Avoid read-past-end of string in get_bold_admin_title (#1499)"}},{"before":"46caa941d3abcadeeacb0543c94a9cf06b37a311","after":"544382f313968c73d77ec801b931dfeefae96346","ref":"refs/heads/master","pushedAt":"2024-05-27T20:43:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Fix mingw and MSVC ci build (#1491)","shortMessageHtmlLink":"Fix mingw and MSVC ci build (#1491)"}},{"before":"47fcc9985343db7738d4185b710cb49254e49dea","after":"46caa941d3abcadeeacb0543c94a9cf06b37a311","ref":"refs/heads/master","pushedAt":"2024-05-27T19:05:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Check allocation results in add_static_user_account (#1501)","shortMessageHtmlLink":"Check allocation results in add_static_user_account (#1501)"}},{"before":"693164cc4dd9d7232dd42018c7fa9effcd360662","after":null,"ref":"refs/heads/solve_bool_issues","pushedAt":"2024-05-27T19:00:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"}},{"before":"846f7170591072eac3627cfd528792cafd80a28c","after":"47fcc9985343db7738d4185b710cb49254e49dea","ref":"refs/heads/master","pushedAt":"2024-05-27T19:00:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Address some build issues introduced by api changes (#1505)\n\n#1502 made APIs consistent with using bool as a return value where true\r\nis success and false is failure\r\nIn a few places the change broke code\r\n\r\nThis PR fixes the breakage","shortMessageHtmlLink":"Address some build issues introduced by api changes (#1505)"}},{"before":null,"after":"693164cc4dd9d7232dd42018c7fa9effcd360662","ref":"refs/heads/solve_bool_issues","pushedAt":"2024-05-27T18:50:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Address some build issues introduced by api changes","shortMessageHtmlLink":"Address some build issues introduced by api changes"}},{"before":"a32d1a270438c0c8be235327b4ef7047edb4e60e","after":"846f7170591072eac3627cfd528792cafd80a28c","ref":"refs/heads/master","pushedAt":"2024-05-27T18:30:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Check the result of calloc in handle_logon_request (#1498)","shortMessageHtmlLink":"Check the result of calloc in handle_logon_request (#1498)"}},{"before":"17926fe70b327318567dfec6f28a23da46952a8e","after":"a32d1a270438c0c8be235327b4ef7047edb4e60e","ref":"refs/heads/master","pushedAt":"2024-05-27T17:56:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Avoid writing potentially uninitialized data to aes_128 key file (#1500)","shortMessageHtmlLink":"Avoid writing potentially uninitialized data to aes_128 key file (#1500)"}},{"before":"90799f5c60ef5444957dbd06303a21e521af2227","after":"17926fe70b327318567dfec6f28a23da46952a8e","ref":"refs/heads/master","pushedAt":"2024-05-27T01:35:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Use active CPU number instead of total number (#1469)\n\nThe code used `get_system_number_of_cpus()` instead of\r\n`get_system_active_number_of_cpus()` to configure number of relay\r\nservers.\r\nThat caused incorrect number to be used on virtualized systems. See\r\n#1468","shortMessageHtmlLink":"Use active CPU number instead of total number (#1469)"}},{"before":"525550ab86a2c5b1e3c4e5cafb09910a79c67f16","after":"90799f5c60ef5444957dbd06303a21e521af2227","ref":"refs/heads/master","pushedAt":"2024-05-27T01:34:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"defined a magic number for stun fingerprinting (#1489)\n\nThe value `0x5354554e`, used twice in the `ns_turn_msg.c`, was unclear,\r\nand was changed to a macro that better explained its usage, as defined\r\nin [RFC\r\n5389](https://datatracker.ietf.org/doc/html/rfc5389#section-15.5)","shortMessageHtmlLink":"defined a magic number for stun fingerprinting (#1489)"}},{"before":"4e8524d9d77f698b3a651237956be1ada2cbacc6","after":"525550ab86a2c5b1e3c4e5cafb09910a79c67f16","ref":"refs/heads/master","pushedAt":"2024-05-27T01:27:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Always run lint, regardless of branch (#1492)\n\nSomeone working on a branch in their own fork won't see the lint running\r\non their github-actions CI until they open a pull request.\r\n\r\nIt'd be much easier to ensure changes being worked on are going to pass\r\nthe linter if the linter runs before the last step of opening the PR.","shortMessageHtmlLink":"Always run lint, regardless of branch (#1492)"}},{"before":"f3b73f60d0eb10863aa2a1d00aa3fa53c551ccd8","after":"4e8524d9d77f698b3a651237956be1ada2cbacc6","ref":"refs/heads/master","pushedAt":"2024-05-27T01:22:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"avoid potential nullptr derefernence in udp_create_server_socket (#1496)","shortMessageHtmlLink":"avoid potential nullptr derefernence in udp_create_server_socket (#1496)"}},{"before":"6fc5cf31e9f269a67d15d03031acc3e264208280","after":"f3b73f60d0eb10863aa2a1d00aa3fa53c551ccd8","ref":"refs/heads/master","pushedAt":"2024-05-27T00:45:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Change the various map functions to return bool instead of inconsistantly return 0, 1, or -1 (#1502)","shortMessageHtmlLink":"Change the various map functions to return bool instead of inconsista…"}},{"before":"2c45aa731c6994887baf7a1f7c11349a06dc50ff","after":"6fc5cf31e9f269a67d15d03031acc3e264208280","ref":"refs/heads/master","pushedAt":"2024-05-27T00:34:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Check the result of malloc in del_alt_server (#1503)","shortMessageHtmlLink":"Check the result of malloc in del_alt_server (#1503)"}},{"before":"74f279d695960855f8042ebe8e376abc596a5818","after":"2c45aa731c6994887baf7a1f7c11349a06dc50ff","ref":"refs/heads/master","pushedAt":"2024-05-27T00:32:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eakraly","name":"Pavel Punsky","path":"/eakraly","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2505440?s=80&v=4"},"commit":{"message":"Avoid nullptr dereference of server variable in various functions (#1504)","shortMessageHtmlLink":"Avoid nullptr dereference of server variable in various functions (#1504"}},{"before":"d72919e4e1320b3f68653087d79405a50e8b6419","after":"74f279d695960855f8042ebe8e376abc596a5818","ref":"refs/heads/master","pushedAt":"2024-05-24T14:56:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"tyranron","name":"Kai Ren","path":"/tyranron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7114909?s=80&v=4"},"commit":{"message":"Upgrade Alpine to 3.20 version in Docker image","shortMessageHtmlLink":"Upgrade Alpine to 3.20 version in Docker image"}},{"before":"14e6d16d14b54f60ed76da891cd8cec9ec1101d1","after":"d72919e4e1320b3f68653087d79405a50e8b6419","ref":"refs/heads/master","pushedAt":"2024-05-14T13:01:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"tyranron","name":"Kai Ren","path":"/tyranron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7114909?s=80&v=4"},"commit":{"message":"Update Debian \"bookworm\" to 20240513 snapshot in Docker image","shortMessageHtmlLink":"Update Debian \"bookworm\" to 20240513 snapshot in Docker image"}},{"before":"158fe9b69895cccbf5e37eaf19361d2f19fa352d","after":"14e6d16d14b54f60ed76da891cd8cec9ec1101d1","ref":"refs/heads/master","pushedAt":"2024-05-05T10:19:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ggarber","name":"Gustavo Garcia","path":"/ggarber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/512252?s=80&v=4"},"commit":{"message":"Fix msvc analyzer error on goto label on rfc5769check (#1486)\n\nrfc5769check.c file is using ERROR as a label for gotos but apparently\r\nthat name is already used for a constant and msvc analyzer detects it as\r\nan error.\r\n\r\nRename it to \"err\" that is already used in other parts of the codebase\r\nand also more consistent in terms of casing.\r\n\r\nCo-authored-by: Gustavo Garcia ","shortMessageHtmlLink":"Fix msvc analyzer error on goto label on rfc5769check (#1486)"}},{"before":null,"after":"8ea9452c0a67f1493c186a4baed89fb912ab39b4","ref":"refs/heads/fix_msvc_analyzer","pushedAt":"2024-05-04T17:13:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ggarber","name":"Gustavo Garcia","path":"/ggarber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/512252?s=80&v=4"},"commit":{"message":"Fix msvc analyzer error on goto label on rfc5769check","shortMessageHtmlLink":"Fix msvc analyzer error on goto label on rfc5769check"}},{"before":"e1d8661b40f5632f85d36c1214245bbc8d36eae2","after":"158fe9b69895cccbf5e37eaf19361d2f19fa352d","ref":"refs/heads/master","pushedAt":"2024-05-04T16:26:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ggarber","name":"Gustavo Garcia","path":"/ggarber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/512252?s=80&v=4"},"commit":{"message":"Fix buffer overflow in generate_enc_password with increase rsalt by 2 (#1463)\n\nbefore this change i see a bufferflow during `readable_string`.","shortMessageHtmlLink":"Fix buffer overflow in generate_enc_password with increase rsalt by 2 ("}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWfZD4gA","startCursor":null,"endCursor":null}},"title":"Activity · coturn/coturn"}