Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt-build pre-hook #151

Open
kokorin opened this issue Sep 26, 2023 · 2 comments · May be fixed by #152
Open

dbt-build pre-hook #151

kokorin opened this issue Sep 26, 2023 · 2 comments · May be fixed by #152
Labels
enhancement New feature or request priority: low

Comments

@kokorin
Copy link

kokorin commented Sep 26, 2023

Describe the feature you'd like
In our DBT project we use snapshot feature. On top of snapshots we build models (views) which contain monthly/weekly data.
Snapshots can be build by using dbt snapshot and dbt build commands.

Now it's not possible to create snapshots with pre-hooks. So every user has to run dbt build command manually before first commit.

Additional context
I think it makes sense to implement pre-hooks for both dbt snapshot and dbt build
@kokorin kokorin added the enhancement New feature or request label Sep 26, 2023
@kokorin kokorin linked a pull request Sep 26, 2023 that will close this issue
Open
@noel
Copy link
Collaborator

noel commented Nov 29, 2023

@kokorin This is not aligned with our plans for checkpoint. We believe that it should focus on the validation hooks vs adding all dbt commands since you can do this via another step in the GH Action.
Is there a reason you would not be able to do that?

@kokorin
Copy link
Author

kokorin commented Nov 29, 2023

Thank you for your reply. Originally we used dbt-checkpoint to validate changed/added models and all upstream models during pre-push hook. But recently our project grew up significantly and now we have 600+ DBT nodes. So we refused from running DBT at pre-push. Instead we validate whole project at CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for dbt-seed, dbt-snapshot and dbt-build kokorin/dbt-checkpoint
3 participants
@noel @kokorin @BAntonellini