Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] saved queries are always selected as "modified", they should not be #10138

Open
2 tasks done
Tracked by #9562
graciegoheen opened this issue May 13, 2024 · 2 comments
Open
2 tasks done
Tracked by #9562
Assignees
Labels
backport 1.8.latest bug Something isn't working Medium Severity bug with minor impact that does not have resolution timeframe requirement

Comments

@graciegoheen
Copy link
Contributor

graciegoheen commented May 13, 2024

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

image (28) (1)

Saved queries are always selected as "modified"

Expected Behavior

Saved queries should only be selected as "modified" when they have been modified

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

@graciegoheen
Copy link
Contributor Author

Potentially related to -> #9548

@graciegoheen graciegoheen added the Medium Severity bug with minor impact that does not have resolution timeframe requirement label May 13, 2024
@tlento
Copy link
Contributor

tlento commented Jun 7, 2024

A community member is reporting the exact opposite behavior - saved queries do not show up in state:modified or state:new even when they should. Here's the repro step sequence they provided in the linked Slack thread:

Steps used for testing:

1. Upgrade existing projects to dbt v1.8
2. Run dbt parse for project containing semantic models
3. Rename target to old-target
4. Edit semantic model (edit existing saved query, add new saved query)
5. Make edits to SQL model as a control for the test
6. Run dbt parse again
7. Run dbt ls -s "state:modified state:new" --target old-target

Result: no semantic model changes detected, SQL model change detected as expected. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest bug Something isn't working Medium Severity bug with minor impact that does not have resolution timeframe requirement
Projects
None yet
Development

No branches or pull requests

3 participants