Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor autocomplete suggests global variable _G #8946

Closed
dri-richard opened this issue May 17, 2024 · 2 comments
Closed

Editor autocomplete suggests global variable _G #8946

dri-richard opened this issue May 17, 2024 · 2 comments
Assignees
@vlaaad
Labels
bug Something is not working as expected editor Issues related to the Defold editor lsp Issues related to the Language Server Protocol

Comments

@dri-richard
Copy link
Contributor

Describe the bug
In some situations, the editor suggests the global variable _G (and other items) when it would be better to suggest nothing.

To Reproduce

  1. In the code editor type an opening curly brace or comma
  2. Notice that a list of suggestions is given, with _G at the top
  3. Hit return
  4. _G has been inserted

Expected behavior
No autocomplete occurs. I can imagine the autocomplete might be more useful after a comma in other situations, maybe a function call.

Defold version:
1.8.0 / 1.8.1 beta

Platforms:

  • Platforms: macOS
  • Device: Macbook Pro

Screenshots :

image
image
image
@dri-richard dri-richard added the bug Something is not working as expected label May 17, 2024
@subsoap
Copy link
Contributor

subsoap commented May 18, 2024

related #8940

@britzl britzl added editor Issues related to the Defold editor lsp Issues related to the Language Server Protocol labels May 20, 2024
vlaaad added a commit that referenced this issue May 20, 2024
@vlaaad
Don't suggest completion popup unnecessarily
3966e68 
The editor no longer shows the completion popup after typing `{` and `,`.

Fixes #8946
@vlaaad vlaaad mentioned this issue May 20, 2024
Merged
vlaaad added a commit that referenced this issue May 20, 2024
@vlaaad
Don't suggest completion popup unnecessarily (#8959)
10362a5 
The editor no longer shows the completion popup after typing `{` and `,`.

Fixes #8946
@vlaaad
Copy link
Contributor

vlaaad commented May 20, 2024

Fixed

@vlaaad vlaaad closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlaaad vlaaad

Labels
bug Something is not working as expected editor Issues related to the Defold editor lsp Issues related to the Language Server Protocol
Projects
1.8.2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@subsoap @vlaaad @britzl @dri-richard