Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): always include config file when publishing #23797

Merged
merged 4 commits into from
May 14, 2024

Conversation

dsherret
Copy link
Member

Closes #23796

@dsherret dsherret requested a review from bartlomieju May 13, 2024 23:52
@dsherret
Copy link
Member Author

Actually, we should just always include the deno.json and ignore the exclude in this case.

@dsherret dsherret changed the title fix(publish): error in --dry-run for excluded deno.json fix(publish): always include config file when publishing May 14, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) May 14, 2024 14:36
@dsherret dsherret merged commit c0e3b6e into denoland:main May 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno publish --dry-run doesn't detect missing deno.json(c) file.
2 participants