Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History enabled by default, but shown as disabled in the settings #2228

Closed
coppolaemilio opened this issue May 14, 2024 · 3 comments
Closed

Comments

@coppolaemilio
Copy link
Collaborator

Dialogic: latest from main
Godot version: 4.3.dev6

I created a test timeline, and noticed that now, on a brand new project, you see the history button at the top.
image
But the project settings have this unchecked:
image

I think the history button should only show if you actively want it by enabling in the settings. So I'd say the settings are correct here and the default template is not.

@coppolaemilio
Copy link
Collaborator Author

Additionally, if you toggle the first checkbox, it will be correct and hide the history button

@Jowan-Spooner
Copy link
Collaborator

Then this is probably a problem with default values.
Usually we assume default values for dialogic settings in multiple places and those assumptions can get out of sync. So I'd assume the game assumes it's on by default, while the settings page considers it off by default. This happens when no actual value has been stored for the setting.

@coppolaemilio
Copy link
Collaborator Author

Makes sense, so I guess the fix would be to disable the history by default on the default theme 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants