Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tenant Id Authentication to the Azure Blob Storage client #1378

Closed
RalfKow opened this issue May 10, 2024 · 4 comments · Fixed by #1377
Closed

Add tenant Id Authentication to the Azure Blob Storage client #1378

RalfKow opened this issue May 10, 2024 · 4 comments · Fixed by #1377
Assignees
@steinitzu

Comments

@RalfKow
Copy link

RalfKow commented May 10, 2024

Source name

filesystem

Describe the data you'd like to see

The filesystem Azure Blob storage has the authentication mechanism [sas_token] with the library https://pypi.org/project/adlfs/.
I would like to add the authentication mechanism used with Tenant_id.

Are you a dlt user?

Yes, I'm already a dlt user.

Do you ready to contribute this extension?

Yes, I'm ready.

dlt destination

snowflake, azure blob storage

Additional information

No response
@rudolfix
Copy link
Collaborator

@steinitzu could you please verify that? I think we support sas token. Maybe we just miss relevant documentation.
most probably this needs to go to dlt core lib. let me know so we can move the issue

@steinitzu
Copy link
Collaborator

Don't think we support this explicitly. Have to look into how to implement. Currently either you pass account key / sas token or default credentials are taken from environment, handled by: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/azure-identity/azure/identity/_credentials/default.py#L29

This is definitely a dlt-core concern

@steinitzu steinitzu mentioned this issue May 16, 2024
Merged
@steinitzu
Copy link
Collaborator

steinitzu commented May 16, 2024 •
edited

@RalfKow for a sneak preview you can try installing dlt from this branch #1377 , see the example credentials in description. Would be great if you let us know if this works for you.

@rudolfix rudolfix transferred this issue from dlt-hub/verified-sources May 17, 2024
@RalfKow
Copy link
Author

RalfKow commented May 22, 2024

I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steinitzu steinitzu

Labels
None yet
Projects
dlt core library
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Azure service principal credentials dlt-hub/dlt
3 participants
@steinitzu @rudolfix @RalfKow