Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL permits set command when write category is allowed but set command is not #3046

Open
safa-topal opened this issue May 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Next Up task that is ready to be worked on and should be added to working queue

Comments

@safa-topal
Copy link

Describe the bug
It's currently possible to run set command when it's disabled in the commands section of ACL along with write category being enabled on the categories section. This behavior is different than Redis ACLs where set command ends up not being permitted.

To Reproduce
Steps to reproduce the behavior:

  1. Add +@write to category section of the ACL and add -set to commands section of the ACL
  2. Issue a set command on an already permitted key
  3. See that set command works

Expected behavior
Set command should not work when it's disabled on commands.

Environment (please complete the following information):

  • Dragonfly Version: 1.16.1
@safa-topal safa-topal added the bug Something isn't working label May 14, 2024
@kostasrim
Copy link
Contributor

Hi @safa-topal, I confirm the bug :) I will get to this.

@kostasrim kostasrim self-assigned this May 14, 2024
@safa-topal
Copy link
Author

Hi @kostasrim thank you.

@adiholden adiholden added the Next Up task that is ready to be worked on and should be added to working queue label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Next Up task that is ready to be worked on and should be added to working queue
Projects
None yet
Development

No branches or pull requests

3 participants