Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting for whether to show comments #55

Open
tagnja opened this issue Apr 17, 2024 · 4 comments
Open

Add a setting for whether to show comments #55

tagnja opened this issue Apr 17, 2024 · 4 comments

Comments

@tagnja
Copy link

tagnja commented Apr 17, 2024

As someone who is not from an English-speaking country, I need to show comments in my native language.

For example:

image
@1ilit
Copy link
Member

1ilit commented Apr 23, 2024

Hey @tagnja, thanks for the suggestion

You can see the comment if you click the more button on the table
image

or hover over the column to see the column comments
image

I think adding comments directly to the diagram would crowd the UI too much

@tagnja
Copy link
Author

tagnja commented May 2, 2024

Comments are not displayed by default. But they can be shown through settings.

If comments are not displayed, it is not possible to export an image with comments.

@psychowood
Copy link

+1 for the suggestion. It is very useful when exporting a diagram.
I'd link it with the "Field Details" view Toggle or to a dedicated toggle under view.

To avoid cramping the UI too much they could be shown below the name when the option is active, something like this:

image

@1ilit
Copy link
Member

1ilit commented May 31, 2024

I'm honestly not a big fan of how it looks. For fields that do have a comment it still looks crammed. If we increase the height of fields to fit comments in there, the fields that don't have a comment will look empty.. idk I'll try to play around with the design to see if I can come up with something nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants