Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Get silently returns an empty []byte for stored []byte values #222

Open
butaca opened this issue Aug 27, 2023 · 2 comments
Open

Redis Get silently returns an empty []byte for stored []byte values #222

butaca opened this issue Aug 27, 2023 · 2 comments

Comments

@butaca
Copy link

butaca commented Aug 27, 2023

The issue is similar to #166 but for Redis with []byte values. When getting a []byte value the cache returns an empty []byte without an error. This is because the Redis implementation always returns strings and fails when trying to convert the value to string. Since it silently fails, it was difficult to debug.

Steps for Reproduction

  1. Set up a cache manager with a Redis store:
redisStore := redis_store.NewRedis(redis.NewClient(&redis.Options{
	Addr: "127.0.0.1:6379",
}))
cacheManager := cache.New[[]byte](redisStore)
  1. Set a []byte value
value := []byte{1, 2, 3, 4}
err := cacheManager.Set(ctx, "key", value, store.WithExpiration(15*time.Second))
if err != nil {
	panic(err)
}
  1. Get the value
cachedValue, err := cacheManager.Get(ctx, "key")
if err != nil {
	panic(err)
}
  1. Check how the returned value has len = 0
fmt.Printf("cached value len: %v\n", len(cachedValue))

Expected behavior:
The returned value is the stored []byte not and empty value

Actual behavior:
It silently returns an empty []byte instead of the stored value

Platforms:
macOS and dockerized Linux from scratch

Versions:
gocache v4.1.3
go 1.21
Redis store v4.2.0
Redis client v9.0.5
Redis server 7.0.12

@butaca butaca changed the title Redis Get silently returns ab empty []byte for stored []byte values Redis Get silently returns an empty []byte for stored []byte values Aug 27, 2023
@luoxiaohei
Copy link

luoxiaohei commented Aug 30, 2023

@eko Maybe we can add a Mashaler and Unmashaler to the cache and allow users to choose whether to use them or not? This will solve the problem of this type mismatch.

update:
The Marshaler package has implemented encapsulation logic for cached data.

@claudiunicolaa
Copy link
Contributor

related #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants