ESQL: fix csv-spec tests expecting a floating result #108560
Labels
:Analytics/ES|QL
AKA ESQL
>bug
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
Comments
bpintea
added
>bug
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
This problem also occurs with queries that create geo |
|
IMHO it's hard to define a single rounding criterion that can be applied to all the spec tests, in some cases we really want to test that the result is really accurate. |
elasticsearchmachine
pushed a commit
that referenced
this issue
May 21, 2024
The test failed repeatedly due to small differences in the final result, especially in multi-node. These differences are only due to the order of double operations https://gradle-enterprise.elastic.co/s/yke3pbfiqsvfo/console-log?page=5 https://gradle-enterprise.elastic.co/s/yjustunaoqnss/console-log?anchor=4650&page=5 Related to #108560
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this issue
May 21, 2024
The test failed repeatedly due to small differences in the final result, especially in multi-node. These differences are only due to the order of double operations https://gradle-enterprise.elastic.co/s/yke3pbfiqsvfo/console-log?page=5 https://gradle-enterprise.elastic.co/s/yjustunaoqnss/console-log?anchor=4650&page=5 Related to elastic#108560
elasticsearchmachine
pushed a commit
that referenced
this issue
May 21, 2024
The test failed repeatedly due to small differences in the final result, especially in multi-node. These differences are only due to the order of double operations https://gradle-enterprise.elastic.co/s/yke3pbfiqsvfo/console-log?page=5 https://gradle-enterprise.elastic.co/s/yjustunaoqnss/console-log?anchor=4650&page=5 Related to #108560
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this issue
May 21, 2024
The test failed repeatedly due to small differences in the final result, especially in multi-node. These differences are only due to the order of double operations https://gradle-enterprise.elastic.co/s/yke3pbfiqsvfo/console-log?page=5 https://gradle-enterprise.elastic.co/s/yjustunaoqnss/console-log?anchor=4650&page=5 Related to elastic#108560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Some tests expecting a floating point result can fail on equality matching.
We should either include in the query a rounding call for them all, or fix the infra to do a range check instead of an exact one.
The text was updated successfully, but these errors were encountered: