Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate timeout parameters from REST requests #108595

Open
nicktindall opened this issue May 14, 2024 · 2 comments
Open

Populate timeout parameters from REST requests #108595

nicktindall opened this issue May 14, 2024 · 2 comments
Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement Team:Distributed Meta label for distributed team

Comments

@nicktindall
Copy link
Contributor

nicktindall commented May 14, 2024

To fix #108224, pull request #108593 brought the documentation into alignment with the current implementation.

When investigating inconsistencies, some opportunities to pass through timeout or master_timeout parameters were identified.

Specifically

  • Delete shutdown API (RestDeleteShutdownNodeAction): could populate timeout from REST request
  • Get shutdown API (RestGetShutdownStatusAction): could populate master_timeout from REST request
  • Put shutdown API (RestPutShutdownNodeAction): could populate timeout from REST request
  • Field usage stats API (RestFieldUsageStatsAction): could populate timeout from REST request
  • Remove policy from index API (RestRemoveIndexLifecyclePolicyAction): could populate timeout from REST request
  • Start watcher service API (RestWatchServiceAction): could populate master_timeout from REST request
  • Delete forecasts API (RestDeleteForecastAction): could populate master_timeout from REST request

See https://docs.google.com/spreadsheets/d/1vsBAt5Z8qAidfW9CcDKtfxXfHv4HBWVicJMwvnkhRfc/edit#gid=0 for full findings

Possible duplicate of/overlap with #107984

@nicktindall nicktindall added >enhancement :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels May 14, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@ywangd
Copy link
Member

ywangd commented May 15, 2024

Related, the following APIs only read cluster state and therefore do not need ackTimeout (parsed from the timeout REST parameter). Currently, they basically silently ignore the timeout. However, removing them can be a breaking change. So I am not suggesting to do so. Mostly writing them down here for future references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement Team:Distributed Meta label for distributed team
Projects
None yet
Development

No branches or pull requests

3 participants