Use scheduleUnlessShuttingDown in LeaderChecker
#108643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mustn't throw an exception here, it trips an assertion. Simply giving up on shutdown is fine. Closes elastic#108642
DaveCTurner
added
>bug
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
| public String toString() { | ||
| return "scheduled check of leader " + leader; | ||
| } | ||
| }); |
There was a problem hiding this comment.
We have similar in FollowerChecker, should that be updated as well?
There was a problem hiding this comment.
Yeah I don't see why not --> #108685
idegtiarenko
approved these changes
May 15, 2024
DaveCTurner
deleted the
2024/05/14/LeaderChecker-scheduleUnlessShuttingDown
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 15, 2024
DaveCTurner
added a commit
that referenced
this pull request
May 16, 2024
nicktindall
pushed a commit
to nicktindall/elasticsearch
that referenced
this pull request
May 17, 2024
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mustn't throw an exception here, it trips an assertion. Simply giving
up on shutdown is fine.
Closes #108642