Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Performance regression in topn #108565

Closed
nik9000 opened this issue May 13, 2024 · 2 comments · Fixed by #108650
Closed

ESQL: Performance regression in topn #108565

nik9000 opened this issue May 13, 2024 · 2 comments · Fixed by #108650
Assignees
@nik9000
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nik9000
Copy link
Member

nik9000 commented May 13, 2024

Description

image

Looks like the jump occurred May 7th.
@nik9000 nik9000 added >enhancement needs:triage Requires assignment of a team area label :Analytics/ES|QL AKA ESQL labels May 13, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 13, 2024
@nik9000 nik9000 self-assigned this May 13, 2024
@nik9000
Copy link
Member Author

nik9000 commented May 14, 2024 via email

nik9000 added a commit to nik9000/elasticsearch that referenced this issue May 14, 2024
@nik9000
ESQL: Speed topn back up
b0726f4 
We noticed a regression in performance for topn last week. It turns out
that we had turned off support for skipping non-competitive docs. We
shouldn' do that!

Closes elastic#108565
nik9000 added a commit to nik9000/elasticsearch that referenced this issue May 14, 2024
@nik9000
ESQL: Speed topn back up
26161ec 
We noticed a regression in performance for topn last week. It turns out
that we had turned off support for skipping non-competitive docs. We
shouldn' do that!

Closes elastic#108565
@nik9000 nik9000 mentioned this issue May 14, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue May 20, 2024
@nik9000
ESQL: Speed topn back up (#108650)
4e1b8bf 
We noticed a regression in performance for topn last week. It turns out
that we had turned off support for skipping non-competitive docs. We
shouldn't do that!

Closes #108565
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this issue May 21, 2024
@nik9000 @jedrazb
ESQL: Speed topn back up (elastic#108650)
a430779 
We noticed a regression in performance for topn last week. It turns out
that we had turned off support for skipping non-competitive docs. We
shouldn't do that!

Closes elastic#108565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Speed topn back up nik9000/elasticsearch
2 participants
@nik9000 @elasticsearchmachine