Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: youtube video in other language #385

Open
sinecode59 opened this issue Jul 31, 2023 · 5 comments 路 May be fixed by #774 or #1362
Open

feature request: youtube video in other language #385

sinecode59 opened this issue Jul 31, 2023 · 5 comments 路 May be fixed by #774 or #1362
Labels
enhancement New feature or request

Comments

@sinecode59
Copy link

馃殌 The feature

Being able to use the "youtube_video" format in other language like for example 'French'.
Today is not working when you put the link of a french youtube video.
Maybe there is a way to define the target language for youtube audio transcription (using Langchain behind) but I've not found any mention about this in the documentation.

Motivation, pitch

Be able to use the 'youtube_video' option with youtube video links not in English (by default)

Alternatives

No response

Additional context

No response
@cachho
Copy link
Contributor

cachho commented Aug 2, 2023

So you want it to be in a language that's not actually spoken in the video, you want to be able to choose from one of the available subtitles. Do I understand that correctly?

@cachho cachho changed the title Youtube video in other language feature request: youtube video in other language Aug 2, 2023
@cachho cachho added the enhancement New feature or request label Aug 2, 2023
@Akemid Akemid linked a pull request Oct 6, 2023 that will close this issue
Open
12 tasks
@avri-schneider
Copy link

@cachho currently only en language is supported. YoutubeLoader.from_youtube_url() allows passing additional parameters (e.g., language), which currently YoutubeVideoLoader.load_data() doesn't pass, thus .from_youtube_url() defaults to en.

@deshraj
Copy link
Collaborator

deshraj commented Feb 27, 2024

Hey @avri-schneider, thanks for reporting the issue. We would appreciate if you can put up a fix for this. Thanks!

@avri-schneider
Copy link

Hey @deshraj the fix is there (provided by Akemid), just needs to be merged, but stalled due to conflics :-/

@deshraj
Copy link
Collaborator

deshraj commented Feb 27, 2024

Ah nice, thanks for bringing to my attention. Will review and merge shortly.

@anantoj anantoj linked a pull request May 9, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@deshraj @avri-schneider @cachho @sinecode59