Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Focus lost in the prompt editing text area onblur #535

Open
1 task
dandv opened this issue May 10, 2024 · 2 comments
Open
1 task

[BUG] Focus lost in the prompt editing text area onblur #535

dandv opened this issue May 10, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@dandv
Copy link
Contributor

dandv commented May 10, 2024

Description

If I edit the prompt and click on another tab, the editing mode will end and the prompt will be Markdown-rendered.

I expect to stay in edit mode, as is the case when I type/edit a prompt in the bottom chat area and click on another tab: when I return to the big-AGI tab, the textarea is still in edit mode.

Device and browser

Firefox 123 on Fedora Linux

Screenshots and more

image

Willingness to Contribute

  • 🙋‍♂️ Yes, I would like to contribute a fix.
@dandv dandv added the type: bug Something isn't working label May 10, 2024
@enricoros
Copy link
Owner

@dandv to fix this, we'll need to have 'save/cancel' button on the prompt editing, and don't really know where to place them on both mobile and desktop (they could be at the top, or bottom, but on mobile they'll be a wide scroll distance away, so blur was the solution.

@dandv
Copy link
Contributor Author

dandv commented May 28, 2024

A more serious bug here: I was in editing mode and pressed Esc to exit editing mode. There WAS a warning but my eyes anticipated it was about losing the changes to the prompt I was editing; instead, all the chats from the beam were lost! ⚠️ (in addition to the prompt).

Would the user actually ever want to lose the model outputs in a beam when pressing Esc? There's also no Undo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants