Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to see Trace Id in Access Logs when request is rate limited (429) #34102

Closed
zirain opened this issue May 13, 2024 · 2 comments
Closed

Unable to see Trace Id in Access Logs when request is rate limited (429) #34102

zirain opened this issue May 13, 2024 · 2 comments
Labels
area/access_log area/tracing enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@zirain
Copy link
Contributor

zirain commented May 13, 2024

%REQ(traceparent)% is not working when request is rate limited

cc @wbpcode
@zirain zirain added bug triage Issue requires triage labels May 13, 2024
@wbpcode
Copy link
Member

wbpcode commented May 16, 2024 •
edited

Yeah. We can extend the substitution formatter to output the trace id and span id (downstream request span id) from the active span directly. As far as I know, the active span is part of the HttpFormatterContext now? So, it should be easy to do that.

@wbpcode wbpcode added enhancement Feature requests. Not bugs or questions. help wanted Needs help! and removed bug area/ratelimit labels May 16, 2024
@zirain
Copy link
Contributor Author

zirain commented May 16, 2024

ok, will add a new formatter %TRACE_ID%.

@zirain zirain mentioned this issue May 16, 2024
Merged
cancecen pushed a commit to cancecen/envoy that referenced this issue May 23, 2024
@zirain @cancecen
accesslog: add %TRACE_ID% formatter (envoyproxy#34198)
2c544e9 
Risk Level: low
Testing: unit test
Docs Changes: formatter documented
Release Notes: add
Fixes envoyproxy#34102
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Can Cecen <ccecen@netflix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/access_log area/tracing enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ravenblackx @zirain @wbpcode