Avoid tab-space mix in compiler output #15033
Labels
low effort
There is not much implementation work to be done. The task is very easy or tiny.
low impact
Changes are not very noticeable or potential benefits are limited.
nice to have
We don’t see a good reason not to have it but won’t go out of our way to implement it.
Projects
After #15026 there remain two sources of random tabs in the sources we store in the repo:
--asm
output are prepended with a tab.I think either of those is unnecessary and removing them would make automatic style checks simpler (less files to exclude). Not only for us but for anyone storing this output in their repository.
Still, this is more of an annoyance than a real issue so I don't expect that we'll work on it any time soon. I'm submitting an issue more to document what I discovered while addressing #15026 than to get someone to actually work on it.
Tabs in SMTChecker output
This happens only if the input file is indented
test.sol
Note that the assert line has leading and trailing tabs.
Note that the assert line is included as is, including the leading and trailing indentation. The
^^^^^
marker repeats that indentation too.Tab as separator in jump labels
Note that
jump // in
includes a tab character as a separator. It seems to be a deliberate decision made in #1330:solidity/libevmasm/AssemblyItem.cpp
Lines 331 to 338 in b61c2a9
The PR does not have any justification for that decision though and it seems to me that using a space there would work just as well.
The text was updated successfully, but these errors were encountered: