Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About contributing to the project #1881

Open
AhmedAbouelkher opened this issue Apr 6, 2024 · 8 comments
Open

About contributing to the project #1881

AhmedAbouelkher opened this issue Apr 6, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@AhmedAbouelkher
Copy link
Contributor

I've been using stats for more than 2 years now and I love it.

I recently tried running the source code on my machine and encountered several issues while doing this.

It would be great if you added a section in README.md showing the steps to clone, explore, and run the project.

@exelban
Copy link
Owner

exelban commented Apr 7, 2024

Hi. Thanks for the feedback)
Yeap, I think it could be added.

@AhmedAbouelkher
Copy link
Contributor Author

Hi. Thanks for the feedback) Yeap, I think it could be added.

Are there any updates regarding the build and run process?

@exelban
Copy link
Owner

exelban commented Apr 19, 2024

hmm, there must be no problem with building and running. Clone the project -> open Xcode -> select profile -> build/run

@AhmedAbouelkher
Copy link
Contributor Author

AhmedAbouelkher commented Apr 19, 2024

hmm, there must be no problem with building and running. Clone the project -> open Xcode -> select profile -> build/run

Thanks for your quick reply. I already tried to do so. Changed the signing certificate to Sign to Run Localy for all modules and started the build process. I encountered these errors:

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "PrivateHeaders/Kit.h"
        ^
/Users/ahmedmahmoud/Developer/macos_apps/stats/Kit/Supporting Files/Kit.h:20:9: error: include of non-modular header inside framework module 'Kit': '/Users/ahmedmahmoud/Developer/macos_apps/stats/Kit/lldb/lldb.h'
#import "lldb.h"
        ^
<unknown>:0: error: could not build Objective-C module 'Kit'
Screenshot 1

Screenshot 2024-04-19 at 22 08 41

Include of non-modular header inside framework module 'Kit': '/Users/ahmedmahmoud/Developer/macos_apps/stats/Kit/lldb/lldb.h'
Screenshot 2

Screenshot 2024-04-19 at 22 09 32

This is the file structure for level DB lldb

Screenshot 3

Screenshot 2024-04-19 at 22 14 30

My Specs:

macOS: Ventura 13.3.1 (22E261)
Xcode: 14.3.1

Clang

Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Target: x86_64-apple-darwin22.4.0
Thread model: posix
InstalledDir: /Applications/Xcode 14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

make

GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

@exelban exelban added the enhancement New feature or request label Apr 21, 2024
@exelban
Copy link
Owner

exelban commented Apr 21, 2024

Oh, why do you change the signing certificate?

Try this: target-> build settings->Allow non-modular includes in Framework Modules switch to YES

@AhmedAbouelkher
Copy link
Contributor Author

@exelban

Oh, why do you change the signing certificate?

Try this: target-> build settings->Allow non-modular includes in Framework Modules switch to YES

I appreciate your suggestion.

When running the project directly without changing the signing cert to Sign to Run Localy .

Screenshot 1

Screenshot 2024-04-22 at 09 48 16


I tried changing Allow non-modular includes in Framework Modules to YES but the issue persists.

I had to change the signing certificate to Sign to Run Locally for all modules and started the build process.

Screenshots 2-3

Screenshot 2024-04-22 at 09 46 13
Screenshot 2024-04-22 at 09 44 46

@exelban
Copy link
Owner

exelban commented Apr 22, 2024

You have selected the signing certificate as the developer id. So you need to specify the team.
Just select Sign to Run Locally and team as None.

@AhmedAbouelkher
Copy link
Contributor Author

You have selected the signing certificate as the developer id. So you need to specify the team. Just select Sign to Run Locally and team as None.

Already did that and tried to build the project, but then I encountered errors in Screenshots 2-3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants