-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode flash #1508
Comments
Thanks for the feedback. I think there might be an influx of bug reports on this one, which I thought would be the case. I did notice this but didn't realize it would be such an issue. I can make this fix. Do you have any tips on the best way to fix it? |
No worries @chrisdel101, you made a good change, and issues will come in identifying gaps. Power of the crowd! If you want to hack on this please do, others may want to fix some of the rough edges too. If we didn't like the change we would just revert it. |
Thank @jonchurch! I will hack. |
- move dark-mode class to html tag - rearrange head order - add document ready checks - remove script tags from markup
There's a flash on page load when user has dark mode set
We can inline the css and js to set up the page before it's rendered to the browser
Slowed down w/ connection throttling:
related #1490
The text was updated successfully, but these errors were encountered: