{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":31927407,"defaultBranch":"main","name":"fboss","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-03-09T23:04:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1706541559.0","currentOid":""},"activityList":{"items":[{"before":"4c75f942054d532f72561f16053823df41adc95c","after":"a6c50b9fe8c8189619f7a9b7853e1e0f54207174","ref":"refs/heads/main","pushedAt":"2024-06-08T02:49:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fboss_link_known_bad_tests_sync\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D58316897\n\nfbshipit-source-id: 1d927396ef12c7d78e6e4ed21b27421c8f2a77c1","shortMessageHtmlLink":"fboss_link_known_bad_tests_sync"}},{"before":"126e1883771b5f93d2af64b85003c0821915c37e","after":"4c75f942054d532f72561f16053823df41adc95c","ref":"refs/heads/main","pushedAt":"2024-06-07T19:42:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"agent sflow mirror test - 3\n\nSummary: sflow mirror when egress port is over LAG\n\nReviewed By: zechengh09\n\nDifferential Revision: D56782510\n\nfbshipit-source-id: 74c9f6b286ea86a20e6f22c12b4d5961d8d98d78","shortMessageHtmlLink":"agent sflow mirror test - 3"}},{"before":"6338e3d547950c028db10c0a299e2a8e3bac8574","after":"126e1883771b5f93d2af64b85003c0821915c37e","ref":"refs/heads/main","pushedAt":"2024-06-07T18:25:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Getdeps for hsthrift\n\nSummary:\nX-link: https://github.com/facebookincubator/hsthrift/pull/134\n\nX-link: https://github.com/facebookincubator/zstrong/pull/873\n\nBuilds and tests hsthrift with the fbthrift dependency.\n\nReviewed By: phlalx\n\nDifferential Revision: D58242707\n\nfbshipit-source-id: 3cebb06e6659615a0077859f64a58fef3b3c5067","shortMessageHtmlLink":"Getdeps for hsthrift"}},{"before":"7d9f6a30ef3bb6796c5f256c743ec9405123b136","after":"6338e3d547950c028db10c0a299e2a8e3bac8574","ref":"refs/heads/main","pushedAt":"2024-06-07T16:36:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/3883631c5869605c73f3e4ecc20efabcde6e9cb4\nhttps://github.com/facebook/fb303/commit/24b2b4d3896db696cb7a293d5318a75b4b1dca47\nhttps://github.com/facebook/fbthrift/commit/165601b51a7bf686cfc9427d62ae86f03f476fb4\nhttps://github.com/facebook/folly/commit/a7e3b7a242383e2217a1efd1fdf51ccc37f0d1a8\nhttps://github.com/facebook/mvfst/commit/3ff5f31c262869a70a210fc46d4871e05dd79e1a\nhttps://github.com/facebook/proxygen/commit/ca9a56a5a1239a24fddd4ee8e2cbfe1dd01b7201\nhttps://github.com/facebook/wangle/commit/076bdcb51d8789321ea0510124c5dcef8a676d21\nhttps://github.com/facebookexperimental/edencommon/commit/e1586778cd0622d0ab51cd69416d5dc5a93a12b4\nhttps://github.com/facebookexperimental/rust-shed/commit/f87aced8dfcb2fffb6702f279428f771f4098eea\nhttps://github.com/facebookincubator/fizz/commit/7a1b1cbfa21f9713368aa5204d13e65202919318\n\nReviewed By: ajb85\n\nfbshipit-source-id: 82ed642f739a391ade0c74abff82fd9d9cebe85c","shortMessageHtmlLink":"Updating submodules"}},{"before":"c2d643f75d54a4ac7ced08dbb5773944e81ea41d","after":"7d9f6a30ef3bb6796c5f256c743ec9405123b136","ref":"refs/heads/main","pushedAt":"2024-06-07T16:23:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix remote interface removal\n\nSummary:\nAs titled. While processing removal of system port and remote interfaces, the check on `getInterfaces` will skip remote interfaces that have sys port already removed.\n\nThis leads to remote intf never deleted from switch state. Fixing it by adding a flag to signify whether to enforce this check. We should skip this check when processing remote inf delta.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision: D58222709\n\nfbshipit-source-id: eef7e08ec2a82c2347657ce35d2d797711a077c9","shortMessageHtmlLink":"Fix remote interface removal"}},{"before":"ee652fc233ffcb51b38d6cc39f1d3ea31012e8a2","after":"c2d643f75d54a4ac7ced08dbb5773944e81ea41d","ref":"refs/heads/main","pushedAt":"2024-06-07T09:35:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace checkFabricReachability with checkFabricConnectivity\n\nSummary:\nGiven the tests are testing connectivity (what is the device connected to) and not\nreachability (what links are used to reach a destination), renaming the APIs to\nFabricConnectivity rather than FabricReachability.\n\nReviewed By: shri-khare\n\nDifferential Revision: D58184183\n\nfbshipit-source-id: 3dc81120846be86c2a116be95db61422bb5645f8","shortMessageHtmlLink":"Replace checkFabricReachability with checkFabricConnectivity"}},{"before":"f08109c60f5e6ad305d1ebbf8d122d1279bfda0f","after":"ee652fc233ffcb51b38d6cc39f1d3ea31012e8a2","ref":"refs/heads/main","pushedAt":"2024-06-07T01:17:54.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Janga DVT fw_util config file\n\nSummary: [FBOSS/Platform] Janga DVT fw_util config file\n\nReviewed By: alandau\n\nDifferential Revision: D58215050\n\nfbshipit-source-id: d9f2c4cdcbe568454ec7de89c98c08fcf6fd1caf","shortMessageHtmlLink":"Janga DVT fw_util config file"}},{"before":"3b77c2e187cd55b785e53902313ff9671e16e547","after":"f08109c60f5e6ad305d1ebbf8d122d1279bfda0f","ref":"refs/heads/main","pushedAt":"2024-06-06T22:46:08.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Minipack3 DVT weutil config file\n\nSummary: [FBOSS/Platform] Minipack3 DVT weutil config file\n\nReviewed By: alandau\n\nDifferential Revision: D58213313\n\nfbshipit-source-id: f59130fb4159f0a4ccd4f0896b98ce0c5cea476a","shortMessageHtmlLink":"Minipack3 DVT weutil config file"}},{"before":"d72990fe3364b656cb15e50cb8482a406be7a225","after":"3b77c2e187cd55b785e53902313ff9671e16e547","ref":"refs/heads/main","pushedAt":"2024-06-06T22:14:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Handle multiple getNextOperDelta requests in sw agent\n\nSummary:\nIn MultiHwSwitchHandler, we have assert to ensure that only client request is ever active. This is generally true even if client dies because we detect client disconnects from streams and cancel any pending requests.\n\nIn a test environment with scaled routes, if the ports are flapped repeatedly, the system slows down and becomes unresponsive (seen in mono as well). In this situation, thrift server will start dropping connections. The streams may not disconnect at this point\n\n```\nE0417 21:06:42.639971 376017 FalconProxySession.cpp:510] subscribeEntities call failed: Load Shedding Due to Queue Timeout: 100 ms.  Please see https://fburl.com/gdoc/xv2z6hu3\nE0417 21:06:42.673589 376017 FalconProxySession.cpp:412] Got error while making subscribe and unsubscribe requests to falcon proxy Load Shedding Due to Queue Timeout: 100 ms.  Please see https://fburl.com/gdoc/xv2z6hu3\n```\nWhen reconnect happens, the old getOperSyncRequest might be still waiting for oper because everything has slowed down. There is an assert to ensure that only one request is in progress and the assert gets hit.\n\nFix:\nInstead of asserting, reply back with empty oper delta and let client retry till old request times out. Also we need to block any state updates while waiting for old client to timeout\n\nReviewed By: zechengh09\n\nDifferential Revision: D56309394\n\nfbshipit-source-id: 7e52e3baf81c0e0b26143182e270f511618591d7","shortMessageHtmlLink":"Handle multiple getNextOperDelta requests in sw agent"}},{"before":"69d1b23d011f7ebbea58cab611b5752e6ab18c9c","after":"d72990fe3364b656cb15e50cb8482a406be7a225","ref":"refs/heads/main","pushedAt":"2024-06-06T22:10:18.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Tahan DVT fw_util config file\n\nSummary: [FBOSS/Platform] Tahan DVT fw_util config file\n\nReviewed By: alandau\n\nDifferential Revision: D58212282\n\nfbshipit-source-id: 355bd99479115ea386299a4d42246b59de505a91","shortMessageHtmlLink":"Tahan DVT fw_util config file"}},{"before":"d8374982e04961ff858f65d91525bdd869e83532","after":"69d1b23d011f7ebbea58cab611b5752e6ab18c9c","ref":"refs/heads/main","pushedAt":"2024-06-06T16:37:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/3803afe4209fab712543a0779d7aeef168a11b0c\nhttps://github.com/facebook/fb303/commit/5a4c37962d38b9a8b8a66eb60e13dbe5ea4d2269\nhttps://github.com/facebook/fbthrift/commit/0ac2d689243be496a6b283b75126a14a6503236e\nhttps://github.com/facebook/folly/commit/fcdc924205c66ff86a78e2b31e2f866288a141a6\nhttps://github.com/facebook/mvfst/commit/32db35ff4f689c971f02b739e3eff1e9835a4aae\nhttps://github.com/facebook/proxygen/commit/42696ea895dc45191974a489cdec97ec5e8348ff\nhttps://github.com/facebook/wangle/commit/1cf03132c4346926ec92d3f2845b18d2cbfcb729\nhttps://github.com/facebookexperimental/edencommon/commit/c039824a2d8b9f362b1e99f6d3e2544b33e9bb20\nhttps://github.com/facebookexperimental/rust-shed/commit/ecc3a6c1fa20245896f303fb3819675ac616a764\nhttps://github.com/facebookincubator/fizz/commit/67d18908b2316d3995f1c8fb8bc7c65acbdcdeb5\n\nReviewed By: ajb85\n\nfbshipit-source-id: d73dc459aceef41b760ccdf9c09efdc879d022b0","shortMessageHtmlLink":"Updating submodules"}},{"before":"61de5cea9c53e7c32abe3c0e929469897c0d8df9","after":"d8374982e04961ff858f65d91525bdd869e83532","ref":"refs/heads/main","pushedAt":"2024-06-06T14:53:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"debug doesn't require build first\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/870\n\nbrainfart\n\nReviewed By: chadaustin\n\nDifferential Revision: D58200715\n\nfbshipit-source-id: ccb02285e672e3e638e6eda92fc0610eb903cb69","shortMessageHtmlLink":"debug doesn't require build first"}},{"before":"3c785c6479a0fcefbbdc24a0af7554cbaeaaf5b2","after":"61de5cea9c53e7c32abe3c0e929469897c0d8df9","ref":"refs/heads/main","pushedAt":"2024-06-06T05:44:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix mac learn check in agent hw tests\n\nSummary: Fixing the retry logic for mac learn check and also addressing an instability in the test\n\nReviewed By: zechengh09\n\nDifferential Revision: D58173775\n\nfbshipit-source-id: 060e470a0434d0ca1d3135f5ea9ab295706d8234","shortMessageHtmlLink":"Fix mac learn check in agent hw tests"}},{"before":"ea78fb3a81b0a8faa58e7ad62002e679cf4b70b0","after":"3c785c6479a0fcefbbdc24a0af7554cbaeaaf5b2","ref":"refs/heads/main","pushedAt":"2024-06-06T05:40:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fboss_sai_agent_known_bad_tests_sync\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D58059293\n\nfbshipit-source-id: 38055a74bcd07f2738b42719c2d08f4a3fadad3b","shortMessageHtmlLink":"fboss_sai_agent_known_bad_tests_sync"}},{"before":"a5161ac56b5a7e6f964dbea96a7b57a09fe9dd34","after":"ea78fb3a81b0a8faa58e7ad62002e679cf4b70b0","ref":"refs/heads/main","pushedAt":"2024-06-05T23:53:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix `fboss_platform_services` build error due to unspecified dependency\n\nSummary:\nhttps://internalfb.com/sandcastle/workflow/3026418949596065825/artifact/actionlog.3026418949655484254.stdout.1?selectedLines=999-999-92-117\n\n```\nFAILED: CMakeFiles/state_utils.dir/fboss/agent/state/StateUtils.cpp.o\n/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DGFLAGS_IS_A_DLL=0 -DIS_OSS=true -DIS_OSS_CPP17=true -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/fb303/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/fatal -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/nlohmann-json-AA3XJJsULRCLk6Clq0kF35PyAyFTdChpo4K5FhU5kXw/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/libsai-iOGKRnIDDiaQFgzHWRc72JXrcowbER2KJx9_B4rPXFo/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/libsai-iOGKRnIDDiaQFgzHWRc72JXrcowbER2KJx9_B4rPXFo/experimental -I/usr/include/libnl3 -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/iproute2-u4AgjJtte4UDdAcpggCKUq_uxWRaeYxTUZFJAvPNIMc/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/yaml-cpp-S7oxEW_LjdQ3Vr4Uux_EX6WdijLe8vX8urR7zUPM3wU/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/libyaml-LmnRHpBlRX5hf6pN0JY9ACzd3uN6jT8YUUi4qKNeSqE/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/exprtk-rBjT1-EkMHnvFh-8k4u0vs4GXXVSzNC6_wjaLvlJqeo -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/googletest-i8rYllf12uJfWbw0H1n4Ux3G_U_GyZlqpiSXenkHkWg/include -I/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/build/fboss -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/gflags-g5RV5ObZF9J_vnk-F5KiX0wwA2Mm8poJ0t8rLCB-EY0/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/glog-h09Fede_TtgxU-_tk9qiTvb9kvFBDvQaUDRn7wXZisg/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/folly/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/boost-ig8PKAbG32vOsOONpYb_25RF1WTE30wVU5WDnIXYrjI/include -isystem /usr/include/libdwarf-0 -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/fmt-HlIOPJoxBVbJ6EvKc8NuB9HczFZ5UhKVbcnIxhrJgqs/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/fbthrift/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/wangle/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/fizz/include -isystem /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/installed/mvfst/include -Wall -Werror -Wno-sign-compare -Wno-maybe-uninitialized -Wno-deprecated-declarations -Os -DNDEBUG -std=gnu++20 -fsized-deallocation -MD -MT CMakeFiles/state_utils.dir/fboss/agent/state/StateUtils.cpp.o -MF CMakeFiles/state_utils.dir/fboss/agent/state/StateUtils.cpp.o.d -o CMakeFiles/state_utils.dir/fboss/agent/state/StateUtils.cpp.o -c /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/StateUtils.cpp\nIn file included from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/thrift_cow/nodes/Types.h:131,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/Thrifty.h:25,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/RouteTypes.h:19,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/RouteNextHopEntry.h:19,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/MatchAction.h:18,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/AclEntry.h:14,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/AclMap.h:13,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/SwitchState.h:21,\n                 from /data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/agent/state/StateUtils.cpp:13:\n/data/sandcastle/temp/skycastle/fbcode_builder_getdeps/shipit/fboss/fboss/thrift_cow/nodes/ThriftPrimitiveNode-inl.h:19:10: fatal error: fboss/fsdb/if/gen-cpp2/fsdb_oper_types.h: No such file or directory\n   19 | #include \"fboss/fsdb/if/gen-cpp2/fsdb_oper_types.h\"\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncompilation terminated.\n```\n\nReviewed By: peygar\n\nDifferential Revision: D58210325\n\nfbshipit-source-id: 4b3676a8ce86e7adedfb0705606f9256345a34f3","shortMessageHtmlLink":"Fix <code>fboss_platform_services</code> build error due to unspecified dependency"}},{"before":"37324f5c46fb10041cc8a122ea714caace1fab48","after":"a5161ac56b5a7e6f964dbea96a7b57a09fe9dd34","ref":"refs/heads/main","pushedAt":"2024-06-05T22:20:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add active state checks for fabricSwitchIsolate as well\n\nSummary: As titled.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision: D56807681\n\nfbshipit-source-id: efbe1833680767137f7e4e7d01e7bb87baecda41","shortMessageHtmlLink":"Add active state checks for fabricSwitchIsolate as well"}},{"before":"c9d13281c76e6946e029e416e0297df92de16e58","after":"37324f5c46fb10041cc8a122ea714caace1fab48","ref":"refs/heads/main","pushedAt":"2024-06-05T21:37:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fboss_qsfp_test_config_sync\n\nDifferential Revision: D58205938\n\nfbshipit-source-id: 513e611abea85e95ece1600fc7a2437d96685b06","shortMessageHtmlLink":"fboss_qsfp_test_config_sync"}},{"before":"e503deaea5fb84353d9a11f341f43092f4ddc608","after":"c9d13281c76e6946e029e416e0297df92de16e58","ref":"refs/heads/main","pushedAt":"2024-06-05T21:29:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deconstruct thrift server after stopping thrift server\n\nSummary:\nAs titled. In agent tests we discovered that TH devices are more likely to encounter memory leak after stopping thrift server -\n\nThe recommended sequence is\n1. Stop thrift server\n2. Deconstruct thrift server such that all threads will be join\n3. exit\n\nSince signal handler and thrift server are on different threads, we need to explicitly wait for thrift server to deconstruct.\n\nReviewed By: msomasundaran\n\nDifferential Revision: D57941514\n\nfbshipit-source-id: 80efcd3c8453ad6c1011a0f48483ba0badb71d23","shortMessageHtmlLink":"Deconstruct thrift server after stopping thrift server"}},{"before":"dd66c268013a7fc06b254427580c887497c006e8","after":"e503deaea5fb84353d9a11f341f43092f4ddc608","ref":"refs/heads/main","pushedAt":"2024-06-05T20:00:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Resolve gcc Compilation Warnings in PRBS Link Testing\n\nSummary: To unblock Cisco in running PRBS link testing, I prevent copy of loop variable by applying reference to all loop variables in the tests.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision: D58194529\n\nfbshipit-source-id: 8a09b9d7089a5f879d64048208202f712da5f3e0","shortMessageHtmlLink":"Resolve gcc Compilation Warnings in PRBS Link Testing"}},{"before":"af03b16ea12d64f69ea71c781188ee97921f6996","after":"dd66c268013a7fc06b254427580c887497c006e8","ref":"refs/heads/main","pushedAt":"2024-06-05T19:25:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix TSAN error when dumping i2c log\n\nSummary:\nThe totalEntries_ was read without lock (during dump), and could be modified by another thread when logging. Fixing that and a few other places (e.g. reading constant value size_ without lock). updating test cases.\n\nAdd explanation of steadclock_ns in log header.\n\nReviewed By: harshitgulati18\n\nDifferential Revision: D58161835\n\nfbshipit-source-id: 25ee12f7df2a4d03670284a3d3d144f5883c6e6f","shortMessageHtmlLink":"Fix TSAN error when dumping i2c log"}},{"before":"024e1d424067e884780a12dc49bac7981b0eed40","after":"af03b16ea12d64f69ea71c781188ee97921f6996","ref":"refs/heads/main","pushedAt":"2024-06-05T19:12:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Run tests in CI (#865)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/zstrong/pull/865\n\nReviewed By: josefs\n\nDifferential Revision: D58134739\n\nfbshipit-source-id: fe61bd381b85b4e4f34c84f12f9aca60bcd6214d","shortMessageHtmlLink":"Run tests in CI (#865)"}},{"before":"b894b82868e8e155c4070c45d5cc9c3974b82a38","after":"024e1d424067e884780a12dc49bac7981b0eed40","ref":"refs/heads/main","pushedAt":"2024-06-05T19:02:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/3467f6869744bc78af857a88eb0336c3d41bc416\nhttps://github.com/facebook/fb303/commit/d79d1f93c8562b107049f4b727a9df1fe8120186\nhttps://github.com/facebook/fbthrift/commit/19a1b58593816dffc378937d671cc9ba8a581cd8\nhttps://github.com/facebook/folly/commit/019c1ed10f2db908da99b851d068df9c0180f208\nhttps://github.com/facebook/mvfst/commit/f06868bc99b034ba909abb8cd6912afa5fd460e4\nhttps://github.com/facebook/proxygen/commit/3a33318f209800f31346f334dc703c555c90491b\nhttps://github.com/facebook/wangle/commit/1562b5f38510c5ce9719acbf2fe2215a8590bf36\nhttps://github.com/facebookexperimental/edencommon/commit/950d4535a1d6c08eb9c081ed2526d5bf3ab9d30c\nhttps://github.com/facebookexperimental/rust-shed/commit/55143223c4e26ba569df9134dea541c0014eaacc\nhttps://github.com/facebookincubator/fizz/commit/1f240e9ccbe99b97744430a7ac87e27c329448d2\n\nReviewed By: ajb85\n\nfbshipit-source-id: ce0bd7a2c6245773e0816167ce8130886584475b","shortMessageHtmlLink":"Updating submodules"}},{"before":"d746033a9ff9db3149ffe991896faca77bf4a819","after":"b894b82868e8e155c4070c45d5cc9c3974b82a38","ref":"refs/heads/main","pushedAt":"2024-06-05T18:51:40.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Implement heartbeats\n\nSummary: sending heartbeats for patch subs\n\nDifferential Revision: D58036375\n\nfbshipit-source-id: 6e84183dc2b05158c9df13f94f270bee4b31660d","shortMessageHtmlLink":"Implement heartbeats"}},{"before":"00990132fa711e0b90a1f10fa9764bda4e229d54","after":"d746033a9ff9db3149ffe991896faca77bf4a819","ref":"refs/heads/main","pushedAt":"2024-06-05T18:30:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add shipit.pathmap to get triggering\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/866\n\nBuild triggering works by using entries in shipit.pathmap, however for\nGlean we're using the native ShipIt so we didn't have these. Add a\ndummy shipit.pathmap section to enable triggering.\n\nReviewed By: josefs\n\nDifferential Revision: D58146311\n\nfbshipit-source-id: 45ce5a707584d834a4de452029cc0699abb0df82","shortMessageHtmlLink":"Add shipit.pathmap to get triggering"}},{"before":"cf0c6ae795c753912707d57c91572ce72dcdd09a","after":"00990132fa711e0b90a1f10fa9764bda4e229d54","ref":"refs/heads/main","pushedAt":"2024-06-05T18:07:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated dynamic exception in fboss/agent/SysError.h +1\n\nSummary:\nLLVM has detected a violation of `-Wdeprecated-dynamic-exception-spec`. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s).\n\nSee [Dynamic exception specification](https://en.cppreference.com/w/cpp/language/except_spec) and [noexcept specifier](https://en.cppreference.com/w/cpp/language/noexcept_spec).\n\nReviewed By: palmje\n\nDifferential Revision: D58182138\n\nfbshipit-source-id: 5494b1b263aaa5e907ac5b1d11673daebb65dbf2","shortMessageHtmlLink":"Fix deprecated dynamic exception in fboss/agent/SysError.h +1"}},{"before":"5a757ee281cd685ea5b535ea6dc21ed121c95886","after":"cf0c6ae795c753912707d57c91572ce72dcdd09a","ref":"refs/heads/main","pushedAt":"2024-06-05T18:02:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"support sub maps in OperPathToPublisherRoot\n\nSummary: Cleaning up this class a little bit and adding types for sub maps needed for patch apis\n\nDifferential Revision: D57172165\n\nfbshipit-source-id: aef28f2c01bac09d81ba0ee1e35ef5b1b3410be2","shortMessageHtmlLink":"support sub maps in OperPathToPublisherRoot"}},{"before":"bf7790325f465e8492a00f54cbf1195337a22ad0","after":"5a757ee281cd685ea5b535ea6dc21ed121c95886","ref":"refs/heads/main","pushedAt":"2024-06-05T17:56:18.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add i2cset to concurrent tests\n\nSummary: I forgot to add the i2cset tests to the concurrent test when it was introduce\n\nReviewed By: mikechoifb\n\nDifferential Revision:\nD58163838\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: ee27d5d47f9761648a59e23c33d3631f1ea96a0f","shortMessageHtmlLink":"Add i2cset to concurrent tests"}},{"before":"630e98d98d3a328684848e7f54f42c4670471bb2","after":"bf7790325f465e8492a00f54cbf1195337a22ad0","ref":"refs/heads/main","pushedAt":"2024-06-05T16:58:38.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix l2table get failures in hwswitch\n\nSummary:\nFixing flakiness in mac learning test due to failure to get l2 entries from hwswitch. If mac entry ages out and a get is attempted, some sai attribute get will return item not found. This is handled for delete here - https://fburl.com/code/0rldarsh\nAdding a similar approach for get as well\n\nReviewed By: zechengh09\n\nDifferential Revision: D58173740\n\nfbshipit-source-id: 37daf28b052101eb08ba949a9a284bea5cfdd195","shortMessageHtmlLink":"Fix l2table get failures in hwswitch"}},{"before":"5477a393719ffa333b868378fe2fcadfe3bb8b5d","after":"630e98d98d3a328684848e7f54f42c4670471bb2","ref":"refs/heads/main","pushedAt":"2024-06-05T16:54:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add hw agent stats for stream/sink events\n\nSummary: Add stats for ipc events in hw agent for ease of debugging\n\nReviewed By: zechengh09\n\nDifferential Revision: D58100665\n\nfbshipit-source-id: 07e3192e6e7afe18c2db34cf2b363159cc835984","shortMessageHtmlLink":"Add hw agent stats for stream/sink events"}},{"before":"78b60ed51548dec2a376f217df3031917f8e39c2","after":"5477a393719ffa333b868378fe2fcadfe3bb8b5d","ref":"refs/heads/main","pushedAt":"2024-06-05T16:36:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/bd99fc8cc87b4b886bbc45b3d4fc5afb80c6eba6\nhttps://github.com/facebook/fb303/commit/2f8b8ee4b4c6a380f6937b55311933b76f5221c8\nhttps://github.com/facebook/fbthrift/commit/dd93cdde2cef08a64bf246882cf7d9b04cbfde99\nhttps://github.com/facebook/folly/commit/ade5b955024e55826667b75e060a5011b251812b\nhttps://github.com/facebook/mvfst/commit/d8bd7d2d5eb64f21ea74b5e2621dce750528bc43\nhttps://github.com/facebook/proxygen/commit/b7bff42119d22b4c42c5fda395c876f26e21f816\nhttps://github.com/facebook/wangle/commit/d1d486f6191580569e41b982057da3b729f98f70\nhttps://github.com/facebookexperimental/edencommon/commit/1a579d8919a91c30d16fd8e03027aebd754f0007\nhttps://github.com/facebookexperimental/rust-shed/commit/de415805d3401f83e16abcdcf1cea2fb82468cc8\nhttps://github.com/facebookincubator/fizz/commit/e92adc2c1a01c8c98f6c287f06a7c6f2ffd43f61\n\nReviewed By: ajb85\n\nfbshipit-source-id: 183de24aa85be1140f3c036207d6ebdd6b529e38","shortMessageHtmlLink":"Updating submodules"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX7nApQA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fboss"}