{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":663573391,"defaultBranch":"main","name":"igl","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-07-07T15:57:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715970600.0","currentOid":""},"activityList":{"items":[{"before":"261c151ebb54456caf45d3fee9a3a79b840fd92f","after":"48cfea1dc2149e38477b521e8ca87f7756993681","ref":"refs/heads/main","pushedAt":"2024-06-01T00:49:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"IGL: Fix Vulkan mipmap generation for cubemaps\n\nSummary: This diff fixes Vulkan mipmap generation for cubemaps.\n\nReviewed By: pixelperfect3, corporateshark\n\nDifferential Revision: D57894232\n\nfbshipit-source-id: b95d74d022aa479a6a7e37ff4b0f96ff05ce0007","shortMessageHtmlLink":"IGL: Fix Vulkan mipmap generation for cubemaps"}},{"before":"c6169d32612a0c4ff90ecab6a0c14b782e77e6f2","after":"261c151ebb54456caf45d3fee9a3a79b840fd92f","ref":"refs/heads/main","pushedAt":"2024-05-31T23:46:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use the viewport scale to set the target size.\n\nSummary: This passes the viewport scale into the Xru Context to set the render target size.\n\nReviewed By: mriegger\n\nDifferential Revision: D58001263\n\nfbshipit-source-id: 30aa6f18af36cb1d8c0617667c1dbf9f9ab9ea21","shortMessageHtmlLink":"Use the viewport scale to set the target size."}},{"before":"a104a63a16ee292fd19cbbef8ca330139c613ab8","after":"c6169d32612a0c4ff90ecab6a0c14b782e77e6f2","ref":"refs/heads/main","pushedAt":"2024-05-31T21:03:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove incorrect collision check\n\nSummary:\nThis check doesn't make sense, consider the following sequence of calls:\n```\n// drawing the first object\nencoder.bindBuffer (0, bufferA)\nencoder.bindVertexBuffer(1, bufferB)\nencoder.draw(...)\n\n// drawing a different object\nencoder.bindBuffer (1, bufferC)\nencoder.bindVertexBuffer(0, bufferD)\nencoder.draw(...)\n```\nThis is perfectly valid (and will work correctly), but this check here determines this to be a collision.\n\nThere is an effect 778223544407551 which issues commands using this pattern and which crashes on IOS due to this check.\n\nReviewed By: EricGriffith, KyleFung, corporateshark\n\nDifferential Revision: D58029138\n\nfbshipit-source-id: 7f266cc965f9e63f6414d527ecdeea5aa063e1a0","shortMessageHtmlLink":"Remove incorrect collision check"}},{"before":"f381f2358aeab9ac496d46174fed0a50003ecb24","after":"a104a63a16ee292fd19cbbef8ca330139c613ab8","ref":"refs/heads/main","pushedAt":"2024-05-31T14:18:36.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor swapchain providers\n\nSummary: Pass image width and height to the swapchain providers instead of `XrViewConfigurationView`, quad layers do not obligatory have sizes equal to XR viewport sizes\n\nReviewed By: EricGriffith\n\nDifferential Revision: D58013263\n\nfbshipit-source-id: a2972fd6eab9235eaee77b661f06c92d108fb950","shortMessageHtmlLink":"Refactor swapchain providers"}},{"before":"d3e0e3d44c2e4c965d83dff83bddd88b2670b874","after":"f381f2358aeab9ac496d46174fed0a50003ecb24","ref":"refs/heads/main","pushedAt":"2024-05-31T13:20:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"22/t - Export AHardwareBuffer from the IGL OpenGL Texture\n\nSummary:\n# This stack\n\nD57825400\n\nSeveral diffs follow to get app side Bitmap creates with a IGL/C++ side hardware texture backing.\n\nThis relies on API level 29 (Hardware buffer stuff was API level 26), and\n* the Bitmap.wrapHardwareBuffer call, which needs a\n* app side HardwareBuffer, which can be obtained from the C++ side via\n* AHardwareBuffer_toHardwareBuffer JNI, but this needs\n* the pointer to the underlying AHardwareBuffer, which is hidden inside\n* the IGL NativeHWBuffer.h class\n\nThe next several diffs walk this information up from the C++ piece, converting and wrapping items as needed.\n\n# This diff\n\nmake the `AHardwareBuffer` public\n\nReviewed By: codyly\n\nDifferential Revision: D57861811\n\nfbshipit-source-id: 558ba2ede202472a066e899298f2c61fd32c2872","shortMessageHtmlLink":"22/t - Export AHardwareBuffer from the IGL OpenGL Texture"}},{"before":"15515bc6dc6675b5a4c8b4f9dfce92a234435b8d","after":"d3e0e3d44c2e4c965d83dff83bddd88b2670b874","ref":"refs/heads/main","pushedAt":"2024-05-31T05:22:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Remove old `multiDrawIndexedIndirect()`\n\nSummary: Removed unused code.\n\nReviewed By: EricGriffith, syeh1, rudybear\n\nDifferential Revision: D57807344\n\nfbshipit-source-id: d9d79ef7bbb97a84ef7e6e3dd1d1c1360c277b7e","shortMessageHtmlLink":"igl | Remove old <code>multiDrawIndexedIndirect()</code>"}},{"before":"8b6ecf5f3207e6b4a0860a39f3aadfef7a1016a4","after":"15515bc6dc6675b5a4c8b4f9dfce92a234435b8d","ref":"refs/heads/main","pushedAt":"2024-05-31T03:33:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Compute max uniform length by taking the max of GL_ACTIVE_UNIFORM_MAX_LENGTH with the max of each GL_UNIFORM_NAME_LENGTH\n\nSummary:\nCompute max uniform length by querying GL_ACTIVE_UNIFORM_MAX_LENGTH, and then taking the max of that with every GL_UNIFORM_NAME_LENGTH of each of the uniforms.\n\nThis is needed because we observed that OpenGL drivers are sometimes unreliable with these values:\n\n1. Android devices with old Mali GPUs (e.g. Mali-T860MP2) sometimes incorrectly return 0 for  GL_ACTIVE_UNIFORM_MAX_LENGTH\n\n2. When running macOS unit tests, sometimes GL_UNIFORM_NAME_LENGTH always return 0\n\nSo the safe thing to do here is to take the max of the two.\n\nReviewed By: dmannemela, syeh1\n\nDifferential Revision: D57974011\n\nfbshipit-source-id: 44cc81e6bcad7619eb17f321a402f92de694b1fa","shortMessageHtmlLink":"Compute max uniform length by taking the max of GL_ACTIVE_UNIFORM_MAX…"}},{"before":"f38d97bb47810328943241917502d9d12885c30d","after":"8b6ecf5f3207e6b4a0860a39f3aadfef7a1016a4","ref":"refs/heads/main","pushedAt":"2024-05-31T01:40:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"XR_FB_COMPOSITION_LAYER_ALPHA_BLEND_EXTENSION_NAME\n\nSummary: subj\n\nReviewed By: MichaelTay\n\nDifferential Revision: D57984278\n\nfbshipit-source-id: 8c8a6c95fd679f915465e5823b930d445e940412","shortMessageHtmlLink":"XR_FB_COMPOSITION_LAYER_ALPHA_BLEND_EXTENSION_NAME"}},{"before":"a591a1079784dd88b083e63f281ea14ac82a07ed","after":"f38d97bb47810328943241917502d9d12885c30d","ref":"refs/heads/main","pushedAt":"2024-05-31T00:50:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Remove old `multiDrawIndirect()`\n\nSummary: Removed unused code.\n\nReviewed By: EricGriffith, rudybear, rameshviswanathan\n\nDifferential Revision: D57806942\n\nfbshipit-source-id: 7fed698cba0f656d4832be11e4a731a3397fb8ff","shortMessageHtmlLink":"igl | Remove old <code>multiDrawIndirect()</code>"}},{"before":"b14b70875c95351bac26c14b091ea0d2b0f30ccb","after":"a591a1079784dd88b083e63f281ea14ac82a07ed","ref":"refs/heads/main","pushedAt":"2024-05-30T18:53:03.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve DPI scaling running app on Windows\n\nSummary: Minor improvement: imGui inside MetaXR Simulator looks much better if Windows doesn't scale it in an arbitrary way. Now it uses DPI for current monitor for proper scaling.\n\nReviewed By: corporateshark\n\nDifferential Revision: D57907062\n\nfbshipit-source-id: 917e076e3ddd90cbe32c0caae666087ba37d5289","shortMessageHtmlLink":"Improve DPI scaling running app on Windows"}},{"before":"592f46b485809894cd9d88521b20effe4c484d25","after":"b14b70875c95351bac26c14b091ea0d2b0f30ccb","ref":"refs/heads/main","pushedAt":"2024-05-30T18:25:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix for missing emplace_back\n\nSummary:\nThe diff titled \"[Stresstest] Fix for missing push_back\" contains code changes in the file \"GPUStressSession.cpp\" in the \"igl/public/shell/renderSessions\" directory. The changes involve fixing a missing push_back operation in the code. The code change is as follows:\n\n```\nparams.layerAlphaBlend_.emplace_back(igl::shell::LayerBlendMode::AlphaBlend);\n```\n\nThis change is necessary to fix a missing push_back operation that was causing a runtime error. The changes were made to ensure that the code runs correctly and does not cause any errors.\n\nReviewed By: EricGriffith, nlutsenko\n\nDifferential Revision: D57929266\n\nfbshipit-source-id: d3ca9d1b703ebe6d1c89897d5b7628a72db419c5","shortMessageHtmlLink":"Fix for missing emplace_back"}},{"before":"a1ad809455294f5ecf3cd22fd42d3b194c000b6d","after":"592f46b485809894cd9d88521b20effe4c484d25","ref":"refs/heads/main","pushedAt":"2024-05-30T16:46:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix for alpha blend layers\n\nReviewed By: rokuz\n\nDifferential Revision: D57930897\n\nfbshipit-source-id: 88a0325a6806126ff2e8093553078dcd5b336d79","shortMessageHtmlLink":"Fix for alpha blend layers"}},{"before":"12431433fd54c56cf803d753ff44ffb076fbad12","after":"a1ad809455294f5ecf3cd22fd42d3b194c000b6d","ref":"refs/heads/main","pushedAt":"2024-05-30T13:01:27.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix XrApp destruction\n\nSummary: Minor fix: Apps crashed on exit. Diff fixes it.\n\nReviewed By: corporateshark\n\nDifferential Revision: D57903595\n\nfbshipit-source-id: cfe83d0c26870e0b4dbebb7eac6f83bd9eeed01b","shortMessageHtmlLink":"Fix XrApp destruction"}},{"before":"9d843b8a4540aa927efaf3b8e4674369d86434ea","after":"12431433fd54c56cf803d753ff44ffb076fbad12","ref":"refs/heads/main","pushedAt":"2024-05-30T07:13:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | vulkan | Use the new function `multiDrawIndirect()`\n\nSummary: Use the new overload of `multiDrawIndirect()` which does not require a primitive.\n\nReviewed By: rudybear\n\nDifferential Revision: D57806860\n\nfbshipit-source-id: 5a478bb43df90cafb2e2e56bec32b3e00c84786c","shortMessageHtmlLink":"igl | vulkan | Use the new function <code>multiDrawIndirect()</code>"}},{"before":"47e0c8e69b2cccdee44bf2c922dc601f94c64400","after":"9d843b8a4540aa927efaf3b8e4674369d86434ea","ref":"refs/heads/main","pushedAt":"2024-05-30T05:25:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Add `multiDrawIndexedIndirect()` overload without `PrimitiveType`\n\nSummary:\nAdded a new `multiDrawIndexedIndirect()` overload which does not need `PrimitiveType`.\n\nThe primitive type is taken from `RenderPipelineDesc::topology`.\n\nReviewed By: EricGriffith, syeh1\n\nDifferential Revision: D57918875\n\nfbshipit-source-id: ae55f6dd77e919b8695b1460281020bf2efcf4c5","shortMessageHtmlLink":"igl | Add <code>multiDrawIndexedIndirect()</code> overload without <code>PrimitiveType</code>"}},{"before":"be85b6e1523de82a39fe72cc52901d93b1032d9a","after":"47e0c8e69b2cccdee44bf2c922dc601f94c64400","ref":"refs/heads/main","pushedAt":"2024-05-30T02:58:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Add `multiDrawIndirect()` overload without `PrimitiveType`\n\nSummary:\nAdded a new `multiDrawIndirect()` overload which does not need `PrimitiveType`.\n\nThe primitive type is taken from `RenderPipelineDesc::topology`.\n\nReviewed By: syeh1, rudybear\n\nDifferential Revision: D57806765\n\nfbshipit-source-id: 3c46b33ad39354607609b18d18d83dc3984bd1d4","shortMessageHtmlLink":"igl | Add <code>multiDrawIndirect()</code> overload without <code>PrimitiveType</code>"}},{"before":"de41cbc4e1ec659bc35925125417d0335a027a23","after":"be85b6e1523de82a39fe72cc52901d93b1032d9a","ref":"refs/heads/main","pushedAt":"2024-05-30T01:48:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | opengl | Support `firstIndex` in `drawIndexed()`\n\nSummary: Support `firstIndex` in `opengl::RenderCommandEncoder::drawIndexed()`.\n\nReviewed By: syeh1, rudybear\n\nDifferential Revision: D57760136\n\nfbshipit-source-id: c5cb2c2341c7094e510541256200a3c562b2190a","shortMessageHtmlLink":"igl | opengl | Support <code>firstIndex</code> in <code>drawIndexed()</code>"}},{"before":"7bb5cc06e0797640fa5ce9630ac3a2693758bd7e","after":"de41cbc4e1ec659bc35925125417d0335a027a23","ref":"refs/heads/main","pushedAt":"2024-05-29T05:10:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | opengl | Add `RenderCommandAdapter::pipelineState()`\n\nSummary: Added a helper function `RenderCommandAdapter::pipelineState()`.\n\nReviewed By: EricGriffith\n\nDifferential Revision: D57806633\n\nfbshipit-source-id: de59f5f24d0bedb78778362da7a8d70b4fcccc1a","shortMessageHtmlLink":"igl | opengl | Add <code>RenderCommandAdapter::pipelineState()</code>"}},{"before":"d27583f8f614d751ddd3d6497033eb8a7c9fb269","after":"7bb5cc06e0797640fa5ce9630ac3a2693758bd7e","ref":"refs/heads/main","pushedAt":"2024-05-25T05:07:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Introduce `RenderPipelineDesc::topology`\n\nSummary:\nIntroduce immutable primitive topology for graphics pipelines to simplify dynamic state management in IGL/Vulkan.\n\nThis is the first diff in the long series.\n\nReviewed By: pixelperfect3, mmaurer\n\nDifferential Revision: D57589728\n\nfbshipit-source-id: 3f33bd2ee6fba624cdb0754dcd1cbba23d0f1312","shortMessageHtmlLink":"igl | Introduce <code>RenderPipelineDesc::topology</code>"}},{"before":"16dbe47f4ad63bba45fa2a1a9e758983e0cc082b","after":"d27583f8f614d751ddd3d6497033eb8a7c9fb269","ref":"refs/heads/main","pushedAt":"2024-05-25T03:39:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | metal | Support `firstIndex` in `drawIndexed()`\n\nSummary:\nSupport `firstIndex` in `metal::RenderCommandEncoder::drawIndexed()`.\n\nImplemented similar to MoltenVK:\n\nhttps://github.com/KhronosGroup/MoltenVK/blob/6b9e55983a6d22eaf96003297119f25256fdf3ba/MoltenVK/MoltenVK/Commands/MVKCmdDraw.mm#L394\n\nReviewed By: rameshviswanathan, mmaurer\n\nDifferential Revision: D57577338\n\nfbshipit-source-id: 76c4307d1a72de114e4d73d7614e0d57e795f233","shortMessageHtmlLink":"igl | metal | Support <code>firstIndex</code> in <code>drawIndexed()</code>"}},{"before":"eb1712974560be4c70cc4943e07b6d743847ecfb","after":"16dbe47f4ad63bba45fa2a1a9e758983e0cc082b","ref":"refs/heads/main","pushedAt":"2024-05-25T02:52:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | tests | Fix validation errors\n\nSummary: Fixed some Vulkan validation errors.\n\nReviewed By: rudybear\n\nDifferential Revision: D57769092\n\nfbshipit-source-id: 83ebd7bd2953c2f7249769e927073a4f0f06ab92","shortMessageHtmlLink":"igl | tests | Fix validation errors"}},{"before":"5141da7441f384f2f5e00f5a626235411829e163","after":"eb1712974560be4c70cc4943e07b6d743847ecfb","ref":"refs/heads/main","pushedAt":"2024-05-25T00:58:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Update obsolete comments\n\nSummary: Updated obsolete comments after the `target` parameter was removed.\n\nReviewed By: EricGriffith\n\nDifferential Revision: D57760135\n\nfbshipit-source-id: 0fb6da666c0abf7d64664155b29b392ab3bf60ac","shortMessageHtmlLink":"igl | Update obsolete comments"}},{"before":"604e0f37f8ad8f598fd0ee63a3f14f9d98285616","after":"5141da7441f384f2f5e00f5a626235411829e163","ref":"refs/heads/main","pushedAt":"2024-05-25T00:37:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Blend modes support\n\nSummary: This diff introduces support for blend modes in the AtlasSandbox app. It includes changes to the XrApp.h and XrApp.cpp files to add support for the XR_FB_composition_layer_alpha_blend extension, as well as changes to the QuadLayerParams.h and GPUStressSession.cpp files to include a new LayerBlendMode enum and support for setting the layer alpha blend mode. The Factory.cpp file includes changes to set the blend mode based on a parameter passed in from the app.\n\nReviewed By: pixelperfect3, corporateshark\n\nDifferential Revision: D57757446\n\nfbshipit-source-id: c9257e618c177c8fdd3509113cd9d9dd97ce9b21","shortMessageHtmlLink":"Blend modes support"}},{"before":"137eab3904aa61a69c7b199065491ad7cda59458","after":"604e0f37f8ad8f598fd0ee63a3f14f9d98285616","ref":"refs/heads/main","pushedAt":"2024-05-24T22:20:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Remove `drawIndexedIndirect()`\n\nSummary:\nRemove unused `drawIndexedIndirect()`.\n\nAlways use `multiDrawIndexedIndirect()` - emulated on Metal and OGL.\n\nReviewed By: EricGriffith, mmaurer\n\nDifferential Revision: D57367444\n\nfbshipit-source-id: 41201ac869312e2e812b374f47a9fd396c2e3558","shortMessageHtmlLink":"igl | Remove <code>drawIndexedIndirect()</code>"}},{"before":"a10188c4c90d6448a9aaf7b04cc3902d88777626","after":"137eab3904aa61a69c7b199065491ad7cda59458","ref":"refs/heads/main","pushedAt":"2024-05-23T01:30:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Fix Intel Mac multisample textures\n\nSummary:\nWe are seeing an error on Intel Mac after adding multisample support in environments of simulator, that suggests we can't enforce storage mode as we are doing now.\n\nWe are explicitly setting the mode to Private, and we need to avoid this override.\n\nError message shows on logview:\n-[MTLTextureDescriptorInternal validateWithDevice:]:1357: failed assertion `Texture Descriptor Validation\nMTLTextureDescriptor: Multisample textures cannot be allocated with MTLStorageModeShared or MTLStorageModeManaged on this device.\n'\n\nReviewed By: pixelperfect3\n\nDifferential Revision: D57357905\n\nfbshipit-source-id: ded7d8391fd43d41ec2b0deffceb284589dce172","shortMessageHtmlLink":"igl | Fix Intel Mac multisample textures"}},{"before":"defb2e8c3e9107230b1883d077f1c5f025a87462","after":"a10188c4c90d6448a9aaf7b04cc3902d88777626","ref":"refs/heads/main","pushedAt":"2024-05-22T22:06:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | metal | Fix `multiDrawIndexedIndirect()` when `stride` is `0`\n\nSummary: Fix `RenderCommandEnvoder::multiDrawIndexedIndirect()` when `stride` is `0`.\n\nReviewed By: mmaurer\n\nDifferential Revision: D57471869\n\nfbshipit-source-id: 5e8542da29249e1e43c317c7b7f7c7f5217a8da2","shortMessageHtmlLink":"igl | metal | Fix <code>multiDrawIndexedIndirect()</code> when <code>stride</code> is <code>0</code>"}},{"before":"14e70aa0ce9a6ea5ba003fcb00573ba14bca271b","after":"defb2e8c3e9107230b1883d077f1c5f025a87462","ref":"refs/heads/main","pushedAt":"2024-05-22T18:26:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Fix crashes in render sessions\n\nSummary: Fix crashes in render sessions when exiting an app.\n\nReviewed By: rameshviswanathan\n\nDifferential Revision: D57471871\n\nfbshipit-source-id: eb46a62ee28c404638fd9fe9766179732b60fa8e","shortMessageHtmlLink":"igl | Fix crashes in render sessions"}},{"before":"6f296c638747aa7a687b6c5f8f5ae12328766d69","after":"14e70aa0ce9a6ea5ba003fcb00573ba14bca271b","ref":"refs/heads/main","pushedAt":"2024-05-22T03:17:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Removing redundant localData_ buffer allocation and memcpy when Vulkan Buffer memory is mapped to CPU.\n\nSummary: This diff removes the redundant localData_ buffer allocation and memcpy when Vulkan Buffer memory is mapped to CPU. The changes made in the Buffer.cpp file include removing the localData_ buffer allocation and memcpy when isRingBuffer_ is true. This change improves performance by reducing unnecessary memory allocation and copying.\n\nReviewed By: syeh1, corporateshark\n\nDifferential Revision: D57500236\n\nfbshipit-source-id: dcca9e800d0af668c6e65d8dce7d009b2703afe9","shortMessageHtmlLink":"Removing redundant localData_ buffer allocation and memcpy when Vulka…"}},{"before":"9954345fb3f5ddf333e30374dae4d7879b749bb4","after":"6f296c638747aa7a687b6c5f8f5ae12328766d69","ref":"refs/heads/main","pushedAt":"2024-05-22T01:44:06.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove image loader from test coverage\n\nSummary: This is test code and should not be included in test coverage\n\nReviewed By: syeh1\n\nDifferential Revision: D57640079\n\nfbshipit-source-id: cc69245b21e8392853b4f15447a6f8b8b71ebc11","shortMessageHtmlLink":"Remove image loader from test coverage"}},{"before":"ef52c6f5578ae3239db8b9a7d5e6ce0d21d1f2d8","after":"9954345fb3f5ddf333e30374dae4d7879b749bb4","ref":"refs/heads/main","pushedAt":"2024-05-22T00:46:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | opengl | Implement `RenderCommandEncoder::multiDrawIndexedIndirect()`\n\nSummary: Emulate  `RenderCommandEncoder::multiDrawIndexedIndirect()` on OpenGL.\n\nReviewed By: rameshviswanathan, mmaurer\n\nDifferential Revision: D57471870\n\nfbshipit-source-id: 735acc57a0c12a4d9b6d955cf91f091c55d0d8c7","shortMessageHtmlLink":"igl | opengl | Implement `RenderCommandEncoder::multiDrawIndexedIndir…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWX3ImAA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/igl"}