-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDE behaves differently when submitted via mouse click vs keyBinding #12858
Comments
It's because of this line:
When the editor is focused, the state is not changed. @danharrin if you think this is a bug, I can create a PR. |
Its deliberate, to prevent an infinite loop of state updates when the editor is being typed into |
Well, what I can say is, from a user POV, it looks like a bug. @alexmanase will your PR overcome the infinite loop? |
I guess. Still looking into it. |
Thank you @bilogic. After checking other solutions, this one seemed to be the best. Let's see if ok for merging. |
Thanks for the fix! |
Package
filament/forms
Package Version
3.2.80
Laravel Version
11.7.0
Livewire Version
3.4.12
PHP Version
8.2.18
Problem description
The behavior of clicking on submit vs pressing the registered
keyBinding()
is different.Clicking will clear the form. (correct)
Pressing the shortcut key does not. (incorrect)
Expected behavior
Pressing the shortcut key should also clear the form.
Steps to reproduce
/admin/issue
ctrl + enter
Reproduction repository
https://github.com/bilogic/filament-issue/tree/click-different-from-keyBindings
Relevant log output
vid.mp4
No response
The text was updated successfully, but these errors were encountered: