-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux framework_tests_misc is 2.02% flaky #148393
Labels
c: flake
Tests that sometimes, but not always, incorrectly pass
f: integration_test
The flutter/packages/integration_test plugin
P0
Critical issues such as a build break or regression
team-framework
Owned by Framework team
Comments
fluttergithubbot
added
c: flake
Tests that sometimes, but not always, incorrectly pass
P0
Critical issues such as a build break or regression
team-framework
Owned by Framework team
labels
May 15, 2024
goderbauer
added
the
f: integration_test
The flutter/packages/integration_test plugin
label
May 21, 2024
Looks like in both cases a native android test for package:integration_test is failing.
|
Yep, I'll take a look |
9 tasks
auto-submit bot
pushed a commit
that referenced
this issue
May 22, 2024
May fix #148393. There are reports on the robolectric issue tracker of >`4.10.3` causing the error we are seeing robolectric/robolectric#8158 The test doesn't actually need robolectric (and didn't originally use it, or flake before using it), but it was added in #144348. We can safely remove it by mocking the call to `View.generateViewId()`, so try removing it and see if flakes go away.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this issue
May 31, 2024
May fix flutter#148393. There are reports on the robolectric issue tracker of >`4.10.3` causing the error we are seeing robolectric/robolectric#8158 The test doesn't actually need robolectric (and didn't originally use it, or flake before using it), but it was added in flutter#144348. We can safely remove it by mocking the call to `View.generateViewId()`, so try removing it and see if flakes go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: flake
Tests that sometimes, but not always, incorrectly pass
f: integration_test
The flutter/packages/integration_test plugin
P0
Critical issues such as a build break or regression
team-framework
Owned by Framework team
The post-submit test builder
Linux framework_tests_misc
had a flaky ratio 2.02% for the past (up to) 100 commits, which is above our 2.00% threshold.One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_misc/17221
Commit: 4c567a9
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_misc/17221
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_misc/17211
Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Linux%20framework_tests_misc
Please follow https://github.com/flutter/flutter/wiki/Reducing-Test-Flakiness#fixing-flaky-tests to fix the flakiness and enable the test back after validating the fix (internal dashboard to validate: go/flutter_test_flakiness).
The text was updated successfully, but these errors were encountered: