Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.11 compat: Use Base.BufferStream for capturing Pkg IO #2915

Merged
merged 11 commits into from
May 21, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented May 9, 2024

implement #2910

Copy link
Contributor

github-actions bot commented May 9, 2024

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="Pkg-IO-capture-BufferStream")
julia> using Pluto

@fonsp fonsp linked an issue May 13, 2024 that may be closed by this pull request
@fonsp
Copy link
Owner Author

fonsp commented May 13, 2024

This PR seems to fix the issue! Except it stalls forever when doing Pkg operations, unless I add lots of logs to debug this, and then it magically works. So I need to figure out which log fixed it and why? (Maybe I need a yield or something?)

@fonsp
Copy link
Owner Author

fonsp commented May 13, 2024

pankgeorg suggested flush(some_io)

@fonsp
Copy link
Owner Author

fonsp commented May 17, 2024

The problem was that I was doing readavailable on a stream that was already fully read, so it was waiting forever for the next byte. The logs "fixed" it because the logs were also printed in this stream, adding bytes.

@fonsp fonsp marked this pull request as ready for review May 17, 2024 08:48
@fonsp
Copy link
Owner Author

fonsp commented May 17, 2024

This fixed it! There is one more Pkg issue that I will maybe do in a separate PR

@fonsp
Copy link
Owner Author

fonsp commented May 21, 2024

last failure is julia-actions/setup-julia#240

@fonsp fonsp merged commit af02d58 into main May 21, 2024
10 of 11 checks passed
@fonsp fonsp deleted the Pkg-IO-capture-BufferStream branch May 21, 2024 17:20
@fonsp fonsp mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia 1.11 beta MemoryRef bounds violation
1 participant