Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): api/users/get-public-profile #54729

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(api): api/users/get-public-profile #54729

wants to merge 15 commits into from
+715 −98

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented May 9, 2024 •
edited

  • test: add some tests for get-public-profile
  • feat: handle missing query and missing users
  • test: add schema test to prevent query use
  • feat: implement responses for locked profile

Checklist:

Post MVP, it would be nice if this just returned what get-session-user returns, but with the private properties null (or omitted). This would both clean up the code and make it clearer what the privacy toggles control.

Closes #54728

@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label May 9, 2024
@ojeytonwilliams ojeytonwilliams force-pushed the feat/get-public-profile branch 2 times, most recently from 46b56d6 to 9295054 Compare May 16, 2024 11:01
@ojeytonwilliams ojeytonwilliams marked this pull request as ready for review May 17, 2024 16:12
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner May 17, 2024 16:12
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
@ojeytonwilliams @ShaunSHamilton
test: add some tests for get-public-profile
00fb429
@ojeytonwilliams @ShaunSHamilton
feat: handle missing query and missing users
ca2e5c2
@ojeytonwilliams @ShaunSHamilton
test: add schema test to prevent query use
f78d26f
@ojeytonwilliams @ShaunSHamilton
feat: implement responses for locked profile
26f5c08
@ojeytonwilliams @ShaunSHamilton
feat: return public user properties
31d09ed
@ojeytonwilliams @ShaunSHamilton
refactor: fix publicUser type
4935c14
@ojeytonwilliams @ShaunSHamilton
feat: add normalizeFlags helper
57a7cbe
@ojeytonwilliams @ShaunSHamilton
fix: response schema + returned data
a58b056
@ojeytonwilliams @ShaunSHamilton
refactor: clarify post-mvp goals
31c38d5
@ojeytonwilliams @ShaunSHamilton
fix: separate saveChallenge body from responses
652d712 
The body is used for validation and so should care about format,
length and so on.

In contrast the response should not be validated because it would mix
concerns (the handler is under our control and should not produce
invalid output).
@ojeytonwilliams @ShaunSHamilton
test: ignore getPublicProfile
c6e297b
@ojeytonwilliams @ShaunSHamilton
fix: import of challenge-types
bed7c0f
@ojeytonwilliams @ShaunSHamilton
chore: clean up
3f26533
@ojeytonwilliams @ShaunSHamilton
refactor: remove private data in separate function
53c3893
ShaunSHamilton
ShaunSHamilton approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Discussed in meeting: The new api returns is2018FullStackCert, but the old api does not. Theoretically, this is a bug in the old api.

@ShaunSHamilton ShaunSHamilton enabled auto-merge (squash) May 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /api/users/get-public-profile
3 participants
@ojeytonwilliams @ShaunSHamilton @moT01