Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface code syntax errors to UI #54734

Closed
lasjorg opened this issue May 10, 2024 · 3 comments
Closed

Surface code syntax errors to UI #54734

lasjorg opened this issue May 10, 2024 · 3 comments
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have

Comments

@lasjorg
Copy link
Contributor

lasjorg commented May 10, 2024

Is your feature request related to a problem? Please describe.

We frequently get forum posts about the submit button not working. It is almost always because the code written has syntax errors preventing the code and tests from running.

Describe the solution you'd like

It would be nice if after the first click/submit the button would change to an error state if the code had syntax errors.

Not really sure how to best surface thrown syntax errors, or when to update/re-update the button state. Maybe on button click, it changes to an error state and on any code update it changes back to the default state until clicked again (where it will stay at the default state or change back to an error state again).

And yes, I realize the error is in the console. But it would be nice to surface it to the UI.

Syntax error

Describe alternatives you've considered

It could be surfaced to some other UI element.

Additional context

As an aside, I'm not sure how we signal code errors to visually impaired users right now. But this change might also count as an accessibility help if the button was updated to signal errors to screen readers.

@lasjorg lasjorg added scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have labels May 10, 2024
@ilenia-magoni
Copy link
Contributor

Now I wonder how accessible is the python terminal... now syntax errors are in the terminal for python, but the terminal updates for every character written in the code window.

@hbar1st
Copy link
Contributor

hbar1st commented May 14, 2024

I’ve seen a design where a red border can be added around the console frame to indicate visually that something is wrong so just wanted to mention it in case it is more desirable than modifying the submit button.

@naomi-lgbt
Copy link
Member

I think this can be marked closed by #54694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have
Projects
None yet
Development

No branches or pull requests

4 participants