-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename project (lockfilehook?) #18
Comments
Sounds a great idea to me! Also, I noticed the readme doesn't mention anything about pnpm or it's lock file. Maybe we could update the docs also ? |
Great opportunity for a recently laid off designer to show off their skills we could all tweet out this thread if you want @frontsideair |
Well I have two opposing ideas about this. On one hand a rename makes sense and probably long overdue. On the other hand it seems like renaming an npm package can only be done by deprecating the package and adding instructions to install the new one. This will definitely hurt adoption and put a burden on users to upgrade for little gain. The truth is I would like to see this project gain major adoption but shortly after I introduced it I was made aware of Yarn PnP and npm tink Basically both projects try to change how dependencies are stored and accessed so it will remove the need for yarnhook. So I think the time this project has is limited. In the light of those two ideas it probably makes more sense to keep the name but add more instructions to the docs. Let me know if it makes sense to you too, or there's anything that you'd like to add. Some questions:
|
I would give my 2 cents on this. Yes, indeed you need to deprecate the previous package on NPM. I would rename the project in github, keeping your stars etc - I presume. And now publish to a new NPM package. I believe deprecated packages no longer show up in the npm search - but it won't break anybody currently using it That way you would have the same repo (with a name change) being published to a NEW npm package. Not sure of any other way of doing this. Publishing to 2 x packages - doesn't seem right to me and AFAIK not possible ? Cheers |
How does pnp eliminate the need for this tool? If you git pull and a new
dependency doesn't exist on a local machine, will pnp just install it at
the time it's actually required?
…On Tue, Apr 7, 2020, 2:02 AM Ian Gregson ***@***.***> wrote:
I would give my 2 cents on this.
Yes, indeed you need to deprecate the previous package on NPM. I would
rename the project in github, keeping your stars etc - I presume.
And now publish to a new NPM package.
I believe deprecated packages no longer show up in the npm search - but it
won't break anybody currently using it
That way you would have the same repo (with a name change) being published
to a NEW npm package.
Not sure of any other way of doing this.
Publishing to 2 x packages - doesn't seem right to me and AFAIK not
possible ?
Cheers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDZKASUYUCEBILXUDKTZLRLLFXJANCNFSM4EXOQGQQ>
.
|
maybe "auto-install-git-hook". Still not sure it's a good idea overall though. Could go for max SEO here too. |
Sorry about radio silence here. Thanks to the hacktoberfest spirit I've decided to spend more time on this. I'm working on adding tests and fixing some serious edge cases so I can do the rename when the project is ready. In the meantime I saw that yarn PnP has not achieved serious adoption and tink is still beta. So yes, I think a rename makes sense. @devinrhode2 "auto-install-git-hook" sounds nice. I also moved away from "lockfilehook" as it's less about lockfiles and more about keeping dependencies up-to-date. Could also use a proper noun, but don't have anything in mind. That's all I have for now. |
It was suggested at #2 and now we have
pnpm
support I'm much more sympathetic to the name. One issue is we already have a neat logo, should we change it to something that looks like a lock?The text was updated successfully, but these errors were encountered: