allow a character override in TC Builds #2160
Conversation
|
[frontend] [Tue May 21 04:31:59 UTC 2024] - Deployed a7905c7 to https://genshin-optimizer-prs.github.io/pr/2160/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue May 21 05:33:22 UTC 2024] - Deployed 3942255 to https://genshin-optimizer-prs.github.io/pr/2160/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue May 21 15:43:42 UTC 2024] - Deployed 1b52d91 to https://genshin-optimizer-prs.github.io/pr/2160/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed May 22 03:56:52 UTC 2024] - Deployed a05e7b7 to https://genshin-optimizer-prs.github.io/pr/2160/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed May 22 05:38:59 UTC 2024] - Deployed e8c20d1 to https://genshin-optimizer-prs.github.io/pr/2160/frontend (Takes 3-5 minutes after this completes to be available) [Wed May 22 05:53:29 UTC 2024] - Deleted deployment |
| @@ -17,6 +18,7 @@ export type BuildTcArtifactSlot = { | |||
| export type BuildTc = { | |||
| name: string | |||
| description: string | |||
| character?: Omit<ICharacter, 'key'> | |||
There was a problem hiding this comment.
No visualization of override here
| @@ -17,6 +18,7 @@ export type BuildTcArtifactSlot = { | |||
| export type BuildTc = { | |||
| name: string | |||
| description: string | |||
| character?: Omit<ICharacter, 'key'> | |||
There was a problem hiding this comment.
More minor, but also no golden numbers here to show these are overridden values
Describe your changes
Add a way to override character base stats (level, constellation, talents) in TC Builds.
Add extra output fields when comparing between builds of different character base stats
Issue or discord link
Testing/validation
Condense the character editor, add a toggle to override the base character
Additional Stat displays to show difference in character base stats
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.