Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Empty Deletion Reason Does Not Trigger Delete Webhook #1159

Open
BellCubeDev opened this issue Jan 23, 2024 · 0 comments
Open

[BUG] Empty Deletion Reason Does Not Trigger Delete Webhook #1159

BellCubeDev opened this issue Jan 23, 2024 · 0 comments
Labels
type: bug something is broken, we need to fix it

Comments

@BellCubeDev
Copy link

Couldn't get that out of the team. Best I got was "presumably the latest". I know there's no billing tab in the admin panel so I do believe we're self-hosted.

Describe the bug
When deleting a suggestion without providing a reason, deletion webhooks aren't triggered.

To Reproduce

  1. If no deletion event webhook exists, create one. Use the built-in test feature to ensure it works before continuing.
  2. Create a dummy suggestion.
  3. As an admin, enter the delete dialog.
  4. Do not provide a delete reason.
  5. Delete the suggestion.
  6. Check your webhook destination. No webhook event should have been sent.

Expected behavior
A webhook event should be sent, even when no deletion reason has been provided. Without these events, knowing whether a suggestion has been removed from an external event log is inconsistent at best.

@BellCubeDev BellCubeDev added the type: bug something is broken, we need to fix it label Jan 23, 2024
@BellCubeDev BellCubeDev changed the title [BUG] [BUG] Empty Deletion Reason Does Not Trigger Delete Webhook Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug something is broken, we need to fix it
Projects
None yet
Development

No branches or pull requests

1 participant