Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support itch.io OAuth2 provider #31016

Open
murl-digital opened this issue May 18, 2024 · 6 comments
Open

Support itch.io OAuth2 provider #31016

murl-digital opened this issue May 18, 2024 · 6 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@murl-digital
Copy link

Feature Description

itch.io provides an OAuth2 provider that I'd like to use on my gitea instance, see the docs here: link

It seems the closest I can do is use OIDC, but it requires a discovery URL that itch.io doesn't have. Is there a way to do this that I don't know about?

Screenshots

No response

@murl-digital murl-digital added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 18, 2024
@techknowlogick techknowlogick added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label May 18, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented May 19, 2024

I don't see think itch.io is a OAuth2 provider. They just support that as authentication for their api?

@murl-digital
Copy link
Author

They have a profile endpoint in the docs, so kind of like discord, you can use it as an auth source: link

@techknowlogick
Copy link
Member

Here are the docs for the oauth provider: https://itch.io/docs/api/oauth

I've tagged this issue as "upstream" as we use goth for working with external oauth providers, and so itch.io support will need to be added there first.

@murl-digital
Copy link
Author

Should I go upstream and open a request myself?

@techknowlogick
Copy link
Member

@murl-digital if you can open one, that would be appreciated, but if not, that's okay, as I'm a maintainer over there, and I am looking into this now. It looks like itch.io doesn't return the user's email, so it might not be feasible to implement it in Gitea (Git and Gitea rely on email addresses and might have unexpected behaviours without one).

@murl-digital
Copy link
Author

murl-digital commented May 20, 2024

(Git and Gitea rely on email addresses and might have unexpected behaviours without one).

For my usecase, at least, I want to give people who bought my software an easy way to make an account and report bugs, and since I handle everything through itch, it kind of just makes sense, and I'm not too worried about email addresses. It seems that profiles have a unique ID, and you can maybe associate it that way? I know that if you set up, say, a GitHub integration, you have the option of signing in to an account or making a new one.

edit: clarity and afterthought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Development

No branches or pull requests

3 participants