Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks can silently fail #57

Open
franciscod opened this issue Feb 1, 2024 · 1 comment
Open

Benchmarks can silently fail #57

franciscod opened this issue Feb 1, 2024 · 1 comment
Labels

Comments

@franciscod
Copy link
Contributor

In the original Convex Hull benchmarks that I added (#51 and fixed in #55), I made a mistake where my number of points was a nice power of 10, which is unfortunately not a multiple of 3, and produced an error that later would stop the run of the intended benchmark.

Confusingly, the numbers still made sense somewhat, so it wasn't immediately obvious that the benchmark was bogus.

Also, since the benchmark "game" window starts fullscreen, it covers the usual debugger tab that would be red and maybe get your attention.

Mistakes like the described above might possibly be catched when adding the benchmark / code review. But it would be nice to detect script errors when running the benchmark: maybe a future (unreleased hopefully) version of the engine mistakenly breaks some feature, and currently the only way to spot it looking at the results would be if the time noticeably changes (likely).


So, what would be a good way of detecting script errors when running a benchmark?

We can add a boolean like ran_ok in the JSON, and another column with "OK" or "ERR" on the GUI.

@Calinou Calinou added the bug label Feb 1, 2024
@Calinou
Copy link
Member

Calinou commented Feb 1, 2024

Also, since the benchmark "game" window starts fullscreen, it covers the usual debugger tab that would be red and maybe get your attention.

This is due to godotengine/godot#80798.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants